Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syscall: js/wasm file operations fail on windows / node.js [1.24 backport] #71977

Closed
gopherbot opened this issue Feb 26, 2025 · 2 comments
Closed

syscall: js/wasm file operations fail on windows / node.js [1.24 backport] #71977

gopherbot opened this issue Feb 26, 2025 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.24.1

Comments

@gopherbot
Copy link
Contributor

@dmitshur requested issue #71758 to be considered for backport to the next 1.24 minor release.

@gopherbot Please add this issue for us to consider for backport to 1.24.

I can be convinced otherwise, but not sure if this meets the bar: the experimental js/wasm port is intended to run in browsers, and uses Node only for testing. This breaks testing support on a Windows host. On the other hand, the backport is very safe and there's no workaround for the affected environment other than modifying the files manually.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Feb 26, 2025
@gopherbot gopherbot mentioned this issue Feb 26, 2025
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Feb 26, 2025
@gopherbot gopherbot added this to the Go1.24.1 milestone Feb 26, 2025
@prattmic prattmic added the CherryPickApproved Used during the release process for point releases label Feb 26, 2025
@dmitshur dmitshur added the Testing An issue that has been verified to require only test changes, not just a test failure. label Feb 26, 2025
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Feb 26, 2025
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/652835 mentions this issue: [release-branch.go1.24] syscall: disable O_DIRECTORY on Windows for js/wasm

@gopherbot
Copy link
Contributor Author

Closed by merging CL 652835 (commit 4070531) to release-branch.go1.24.

gopherbot pushed a commit that referenced this issue Feb 26, 2025
@Zxilly @prattmic
[release-branch.go1.24] syscall: disable O_DIRECTORY on Windows for j…
4070531 
…s/wasm

O_DIRECTORY is not available on all platforms, as described at

https://nodejs.org/docs/latest/api/fs.html#file-open-constants .

On Windows, only O_APPEND, O_CREAT, O_EXCL, O_RDONLY, O_RDWR,
O_TRUNC, O_WRONLY, and UV_FS_O_FILEMAP are available.

For #71758.
Fixes #71977.

Change-Id: Iacc890ba9a30dcd75eb746ec324fa0c3e368048e
GitHub-Last-Rev: a0160e8
GitHub-Pull-Request: #71770
Reviewed-on: https://go-review.googlesource.com/c/go/+/650015
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Bypass: Dmitri Shuralyov <dmitshur@golang.org>
(cherry picked from commit ad8b330)
Reviewed-on: https://go-review.googlesource.com/c/go/+/652835
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.24.1
Development

No branches or pull requests
3 participants
@prattmic @dmitshur @gopherbot