testing: modify got,want equal comparison for unordered example output #72025

callthingsoff · 2025-02-28T14:48:42Z

This change eliminates sortLines function to avoid strings.Join calls.

It's not a performance problem, this change tries to make the comparison
more straightforward.

gopherbot · 2025-02-28T14:55:47Z

This PR (HEAD: a2b991c) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/653556.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-02-28T15:58:46Z

Message from Alan Donovan:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/653556.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-28T20:57:01Z

Message from Ian Lance Taylor:

Patch Set 1: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/653556.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-28T20:57:02Z

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-02-28T20:46:00Z","revision":"cf9ef6cd81aa7fd3e3107761f3e500ced978bc83"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/653556.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-28T21:16:47Z

Message from Ian Lance Taylor:

Patch Set 1: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/653556.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-28T21:16:48Z

Message from Go LUCI:

Patch Set 1:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/653556.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-28T21:16:48Z

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/653556.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-01T03:41:53Z

Message from Jes Cok:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/653556.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-01T04:56:43Z

This PR (HEAD: a9091fa) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/653556.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-03-01T05:21:54Z

Message from Jes Cok:

Patch Set 6: Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/653556.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-01T05:21:55Z

Message from Go LUCI:

Patch Set 6:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-03-01T05:10:46Z","revision":"c8c6b22326022a23ab5e58ca3220a3bc71ee8318"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/653556.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-01T05:34:34Z

Message from Jes Cok:

Patch Set 6: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/653556.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-01T05:34:35Z

Message from Go LUCI:

Patch Set 6:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-linux-amd64 has failed with summary (view all results):

go on master (change 653556)

Build or test failure, click here for results.

To reproduce, try gomote repro 8721626472052989793.

Additional links for debugging:

Output for go tool dist test -json [shard 1]

Please don’t reply on this GitHub thread. Visit golang.org/cl/653556.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-01T05:34:35Z

Message from Go LUCI:

Patch Set 6: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/653556.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-01T05:59:40Z

Message from Jes Cok:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/653556.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-01T05:59:47Z

This PR (HEAD: b2c5a2a) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/653556.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-03-01T06:12:22Z

Message from Ian Lance Taylor:

Patch Set 7: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/653556.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-01T06:18:35Z

Message from Go LUCI:

Patch Set 7:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-03-01T06:06:22Z","revision":"3b11b49ff1c502b58cba9ca6441ff4891c6add99"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/653556.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-01T06:38:40Z

Message from Ian Lance Taylor:

Patch Set 7: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/653556.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-01T06:38:40Z

Message from Go LUCI:

Patch Set 7:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/653556.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-01T06:38:41Z

Message from Go LUCI:

Patch Set 7: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/653556.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-02T07:46:57Z

This PR (HEAD: 035cf3a) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/653556.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-03-02T07:59:21Z

Message from Jes Cok:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/653556.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-02T07:59:22Z

Message from Jes Cok:

Patch Set 9: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/653556.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-02T08:05:35Z

Message from Go LUCI:

Patch Set 9:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-03-02T07:53:38Z","revision":"5935cdcec296e6e1526479ea7e5b431f53bfbade"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/653556.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-02T08:25:10Z

Message from Jes Cok:

Patch Set 9: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/653556.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-02T08:25:11Z

Message from Go LUCI:

Patch Set 9:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/653556.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-02T08:25:11Z

Message from Go LUCI:

Patch Set 9: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/653556.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-02T10:32:08Z

Message from Milan Jadavan:

Patch Set 9:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/653556.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-03T06:57:22Z

Message from Ian Lance Taylor:

Patch Set 9:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/653556.
After addressing review feedback, remember to publish your drafts!

Introduce sortedLinesEqual function which avoids strings.Join calls, and replace strings equal comparation with slices.Equal.

gopherbot · 2025-03-03T13:34:19Z

This PR (HEAD: a71aa58) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/653556.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-03-03T13:48:33Z

Message from Jes Cok:

Patch Set 10: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/653556.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-03T13:48:34Z

Message from Go LUCI:

Patch Set 10:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-03-03T13:37:30Z","revision":"269e5f9c003281ff8534cfe2bdc605f85b0781d9"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/653556.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-03T14:09:09Z

Message from Jes Cok:

Patch Set 10: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/653556.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-03T14:09:10Z

Message from Go LUCI:

Patch Set 10:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/653556.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-03T14:09:10Z

Message from Go LUCI:

Patch Set 10: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/653556.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-03T14:15:58Z

Message from Jes Cok:

Patch Set 10:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/653556.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-04T06:34:57Z

Message from Ian Lance Taylor:

Patch Set 10: Auto-Submit+1 Code-Review+2 Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/653556.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-04T06:34:57Z

Message from Go LUCI:

Patch Set 10:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-03-04T06:30:36Z","revision":"269e5f9c003281ff8534cfe2bdc605f85b0781d9"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/653556.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-04T07:01:58Z

Message from Ian Lance Taylor:

Patch Set 10: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/653556.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-04T07:01:59Z

Message from Go LUCI:

Patch Set 10:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/653556.
After addressing review feedback, remember to publish your drafts!

This change eliminates sortLines function to avoid strings.Join calls. It's not a performance problem, this change tries to make the comparison more straightforward. Change-Id: I3a7ae877c9fc927833ab9f143205f7e007197f60 GitHub-Last-Rev: a71aa58 GitHub-Pull-Request: #72025 Reviewed-on: https://go-review.googlesource.com/c/go/+/653556 Reviewed-by: Junyang Shao <shaojunyang@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Ian Lance Taylor <iant@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com>

gopherbot · 2025-03-05T15:52:56Z

This PR is being closed because golang.org/cl/653556 has been merged.

callthingsoff changed the title ~~testing: optimize got,want equal comparison for unordered example output~~ testing: change got,want equal comparison for unordered example output Mar 1, 2025

callthingsoff force-pushed the testing_opt branch from a2b991c to a9091fa Compare March 1, 2025 04:56

callthingsoff force-pushed the testing_opt branch from a9091fa to b2c5a2a Compare March 1, 2025 05:58

callthingsoff force-pushed the testing_opt branch from b2c5a2a to 035cf3a Compare March 2, 2025 07:43

callthingsoff changed the title ~~testing: change got,want equal comparison for unordered example output~~ testing: modify got,want equal comparison for unordered example output Mar 2, 2025

testing: optimize got,want equal comparison for unordered example output

a71aa58

Introduce sortedLinesEqual function which avoids strings.Join calls, and replace strings equal comparation with slices.Equal.

callthingsoff force-pushed the testing_opt branch from 035cf3a to a71aa58 Compare March 3, 2025 13:31

gopherbot closed this Mar 5, 2025

callthingsoff deleted the testing_opt branch March 5, 2025 16:12

testing: modify got,want equal comparison for unordered example output #72025

testing: modify got,want equal comparison for unordered example output #72025

Conversation

callthingsoff commented Feb 28, 2025 • edited Loading

gopherbot commented Feb 28, 2025

gopherbot commented Feb 28, 2025

gopherbot commented Feb 28, 2025

gopherbot commented Feb 28, 2025

gopherbot commented Feb 28, 2025

gopherbot commented Feb 28, 2025

gopherbot commented Feb 28, 2025

gopherbot commented Mar 1, 2025

gopherbot commented Mar 1, 2025

gopherbot commented Mar 1, 2025

gopherbot commented Mar 1, 2025

gopherbot commented Mar 1, 2025

gopherbot commented Mar 1, 2025

gopherbot commented Mar 1, 2025

gopherbot commented Mar 1, 2025

gopherbot commented Mar 1, 2025

gopherbot commented Mar 1, 2025

gopherbot commented Mar 1, 2025

gopherbot commented Mar 1, 2025

gopherbot commented Mar 1, 2025

gopherbot commented Mar 1, 2025

gopherbot commented Mar 2, 2025

gopherbot commented Mar 2, 2025

gopherbot commented Mar 2, 2025

gopherbot commented Mar 2, 2025

gopherbot commented Mar 2, 2025

gopherbot commented Mar 2, 2025

gopherbot commented Mar 2, 2025

gopherbot commented Mar 2, 2025

gopherbot commented Mar 3, 2025

gopherbot commented Mar 3, 2025

gopherbot commented Mar 3, 2025

gopherbot commented Mar 3, 2025

gopherbot commented Mar 3, 2025

gopherbot commented Mar 3, 2025

gopherbot commented Mar 3, 2025

gopherbot commented Mar 3, 2025

gopherbot commented Mar 4, 2025

gopherbot commented Mar 4, 2025

gopherbot commented Mar 4, 2025

gopherbot commented Mar 4, 2025

gopherbot commented Mar 5, 2025

callthingsoff commented Feb 28, 2025 •

edited

Loading