Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise exception when startup events fail due to inaccessible localhost #10739

Merged

Conversation

Mywifi
Copy link
Contributor

@Mywifi Mywifi commented Mar 6, 2025

Description

This PR addresses an issue where the Gradio application stalls indefinitely when localhost is inaccessible, causing startup events to fail silently.

Specifically, when using share=True with a proxy that blocks localhost, the httpx.get request to {self.local_api_url}startup-events fails, and the event queue is never processed, resulting in components (e.g., dropdown triggers) loading forever.

Closes: #10729

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Mar 6, 2025

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
🦄 Changes failed! Workflow log

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/7d1d897a8aea95fc3e61dbba4fc56649099bd7e4/gradio-5.20.1-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@7d1d897a8aea95fc3e61dbba4fc56649099bd7e4#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/7d1d897a8aea95fc3e61dbba4fc56649099bd7e4/gradio-client-1.13.1.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/7d1d897a8aea95fc3e61dbba4fc56649099bd7e4/dist/lite.js""></script>

@gradio-pr-bot
Copy link
Collaborator

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Raise exception when startup events fail due to inaccessible localhost

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

Sorry, something went wrong.

Copy link
Collaborator

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Mywifi !

@Mywifi Mywifi force-pushed the fix-startup-events-localhost-error branch from 43309d0 to 7d1d897 Compare March 7, 2025 11:56
@abidlabs
Copy link
Member

abidlabs commented Mar 7, 2025

Thanks @Mywifi! Merging

@abidlabs abidlabs merged commit fb99709 into gradio-app:main Mar 7, 2025
22 checks passed
@Mywifi Mywifi deleted the fix-startup-events-localhost-error branch March 8, 2025 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Infinite Loading When Localhost is Unreachable in Startup Events
4 participants