Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed size for pending thoughts #10671

Merged
merged 10 commits into from
Mar 12, 2025
Merged

Fixed size for pending thoughts #10671

merged 10 commits into from
Mar 12, 2025

Conversation

dawoodkhan82
Copy link
Collaborator

Description

Shows a fixed size box when thought messages are pending (5 lines). Since we now show a "preview", expanded is false by default.

Untitled.mov

Closes: #(issue)

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Testing and Formatting Your Code

  1. PRs will only be merged if tests pass on CI. We recommend at least running the backend tests locally, please set up your Gradio environment locally and run the backed tests: bash scripts/run_backend_tests.sh

  2. Please run these bash scripts to automatically format your code: bash scripts/format_backend.sh, and (if you made any changes to non-Python files) bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Feb 25, 2025

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/ae7ff0f2b69d8df10e04499b6ce20c75cde34f61/gradio-5.20.1-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@ae7ff0f2b69d8df10e04499b6ce20c75cde34f61#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/ae7ff0f2b69d8df10e04499b6ce20c75cde34f61/gradio-client-1.13.1.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/ae7ff0f2b69d8df10e04499b6ce20c75cde34f61/dist/lite.js""></script>

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Feb 25, 2025

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/chatbot patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fixed size for pending thoughts

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@abidlabs
Copy link
Member

I like the UI! Although I'm not sure if this works with nested thoughts: if you run demo/chatinterface_nested_thoughts/run.py there's no way to see the nested thoughts even after the thoughts have completed running:

image

@dawoodkhan82
Copy link
Collaborator Author

@abidlabs fixed

@abidlabs abidlabs added the v: patch A change that requires a patch release label Mar 6, 2025
@abidlabs
Copy link
Member

abidlabs commented Mar 6, 2025

I think this looks good, but perhaps it'd be good to get a second opinion from @yvrjsharma or @aymeric-roucher

@dawoodkhan82 dawoodkhan82 enabled auto-merge (squash) March 12, 2025 17:32
@dawoodkhan82 dawoodkhan82 merged commit cae5517 into main Mar 12, 2025
23 of 24 checks passed
@dawoodkhan82 dawoodkhan82 deleted the thought-restyle branch March 12, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v: patch A change that requires a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants