Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows path issue in FileExplorer #10735

Merged
merged 6 commits into from
Mar 7, 2025
Merged

Fix windows path issue in FileExplorer #10735

merged 6 commits into from
Mar 7, 2025

Conversation

aliabid94
Copy link
Collaborator

@aliabid94 aliabid94 commented Mar 5, 2025

Fixes: #9918, Fixes: #9715

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Mar 5, 2025

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
🦄 Changes detecting...

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/b75c09cdf129e41eade09f57740ba85acf3cfc6d/gradio-5.20.1-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@b75c09cdf129e41eade09f57740ba85acf3cfc6d#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/b75c09cdf129e41eade09f57740ba85acf3cfc6d/gradio-client-1.13.1.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/b75c09cdf129e41eade09f57740ba85acf3cfc6d/dist/lite.js""></script>

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Mar 5, 2025

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fix windows path issue in FileExplorer

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@SecretLittleBoy
Copy link

Your code can not work well on windows.
I find the error in your code:

        if os.name == "nt":
            combined_path = combined_path.replace("/", "\\")

should be

        if os.name == "nt":
            combined_path = combined_path.replace("\\", "/")

After this modification, it can work well.

@aliabid94 aliabid94 marked this pull request as ready for review March 7, 2025 20:14
@abidlabs abidlabs requested a review from freddyaboulton March 7, 2025 21:42
Copy link
Collaborator

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @aliabid94 !

@abidlabs
Copy link
Member

abidlabs commented Mar 7, 2025

Will go ahead and merge this in!

@abidlabs abidlabs merged commit dd2de17 into main Mar 7, 2025
22 checks passed
@abidlabs abidlabs deleted the fix_windows_path branch March 7, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants