Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new output #12

Merged
merged 7 commits into from
Sep 10, 2018
Merged

Implement new output #12

merged 7 commits into from
Sep 10, 2018

Conversation

pxlpnk
Copy link
Contributor

@pxlpnk pxlpnk commented Sep 5, 2018

@pxlpnk pxlpnk requested review from a user and streichsbaer September 5, 2018 09:21
@ghost ghost assigned pxlpnk Sep 5, 2018
@ghost ghost added the review label Sep 5, 2018
@guardrails
Copy link

guardrails bot commented Sep 5, 2018 •
edited
Loading

⚠️ We detected security issues in this pull request:

Compromised Secrets (16)

@guardrails-staging
Copy link

guardrails-staging bot commented Sep 5, 2018 •
edited
Loading

⚠️ We detected security issues in this pull request:

Hard-coded Secrets (16)

More info on how to fix Hard-coded Secrets.

streichsbaer
streichsbaer approved these changes Sep 5, 2018
View reviewed changes
Copy link
Contributor

@streichsbaer streichsbaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ghost ghost assigned streichsbaer Sep 9, 2018
@streichsbaer
Copy link
Contributor

@pxlpnk I hi-jacked the PR to add a few minor changes.

  • scope and private flag in the package.json
  • added general as a language. Currently, the secret engine says all as language, but I think it would be good to make it conform with guardrails-engine-{language}-..., which is general for secrets.

Hope that's ok.

@ghost ghost self-assigned this Sep 10, 2018
@pxlpnk
Copy link
Contributor Author

pxlpnk commented Sep 10, 2018

Yes this makes a lot of sense, thank you!

@pxlpnk pxlpnk merged commit 4b862b0 into master Sep 10, 2018
@ghost ghost removed the review label Sep 10, 2018
@pxlpnk pxlpnk deleted the feat/implement-new-output branch September 10, 2018 09:25
@smchai
Copy link

smchai commented Sep 10, 2018

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@ghost ghost unassigned pxlpnk Dec 20, 2018
@streichsbaer streichsbaer unassigned ghost Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@streichsbaer streichsbaer

Assignees

@streichsbaer streichsbaer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pxlpnk @streichsbaer @smchai