Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to suit dast-owasp-zap #30

Merged
merged 6 commits into from
Feb 28, 2022

Conversation

binarymist
Copy link
Contributor

@binarymist binarymist commented Feb 22, 2021

Add sutUrl to envelopeSchema.
Add lineitem location alternative.
Add metadataSchemaDAST for dast.

@streichsbaer do you have any spare engine outputs you can throw at this to verify I haven't broken anything?

Validates dast-owasp-zap fine now.

Add sutUrl to envelopeSchema.
Add lineitem location alternative.
Add metadataSchemaDAST for dast.
Copy link

@guardrails-test guardrails-test left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll run some more tests later today on other outputs

@binarymist
Copy link
Contributor Author

Was there a reason this never got merged @streichsbaer ?

@streichsbaer
Copy link
Contributor

Was there a reason this never got merged @streichsbaer ?

Yes, because we haven't deployed the DAST engine to production and as a result forgot to merge this.

Copy link
Contributor

@streichsbaer streichsbaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@binarymist binarymist merged commit b40e9f7 into master Feb 28, 2022
@binarymist binarymist deleted the binarymist/adjust-for-dast-owasp-zap branch February 28, 2022 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants