[POC] feat: Hono Action #3973
Open
[POC] feat: Hono Action #3973
+274
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Yusuke Wada <yusuke@kamawada.com>
This comment has been minimized.
This comment has been minimized.
Bundle size check
Compiler Diagnostics
Reported by octocov |
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (6.54%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #3973 +/- ##
==========================================
- Coverage 91.29% 89.66% -1.63%
==========================================
Files 168 170 +2
Lines 10772 10895 +123
Branches 3057 3029 -28
==========================================
- Hits 9834 9769 -65
- Misses 937 1125 +188
Partials 1 1 ☔ View full report in Codecov by Sentry. |
|
Hey @usualoma ! Shall we work on Hono Action as just POC? I think Hono Action will be super helpful with using HonoX. In this PR, it throws the following error. Can you take a look at it? App: import { Hono } from '../../src'
import { createAction } from '../../src/jsx/action'
import { jsxRenderer } from '../../src/middleware/jsx-renderer'
const renderer = jsxRenderer(
({ children }) => {
return (
<html>
<body>
<main>{children}</main>
</body>
</html>
)
},
{
stream: true,
}
)
const app = new Hono()
app.use(renderer)
const [action, Component] = createAction(app, async (data, c) => {
return <></>
})
app.get('/', (c) => {
return c.render(
<section>
<form>
<Component />
</form>
</section>
)
})
export default appError:
|
|
I'll check; give me a few days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP