Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated build scripts and rewrote development instructions #309

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

aaronjeromsky
Copy link

Problem

Me and my team at CodeDay encountered a command not found error when executing the build scripts from the HOPP_EXTENSION_TARGET command. In addition, the copyfiles command fails to execute, resulting in an incomplete build output to the dist folder.

Solution

A set statement has been added to the beginning of the build scripts to allow for the HOPP_EXTENSION_TARGET system variable to be set. A second && has been added between the parcel and copyfiles commands to ensure each one is executed sequentially.

Additional Changes

The development section of the documentation has been rewritten with the goal of providing additional clarity for the build instructions, such as specifying the usage of a Git Bash command-line. In our testing, the PowerShell environment was unable to run either version of the build scripts due to requiring a different syntax for handling sequential lines.

Summary

  • Add set to beginning of build scripts
  • Add && before copyfiles command in build scripts
  • Rewrote development instructions for clarity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant