Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(polars): support lag and lead #10914

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

GLeurquin
Copy link

Description of changes

Add support for polars Lag and Lead operations

@github-actions github-actions bot added the polars The polars backend label Feb 28, 2025
@GLeurquin
Copy link
Author

I don't quite know where to add tests for this, if you guide me I can modify the PR to add them

@cpcloud
Copy link
Member

cpcloud commented Mar 3, 2025

This requires a lot more work. Because of the way Ibis models window functions, a backend that wants to support them must support compiling ops.WindowFunction first, and then implement support for the individual functions.

@GLeurquin GLeurquin force-pushed the feat/polars-lag-lead branch from 57574d2 to dd1c2c6 Compare March 3, 2025 16:00
@GLeurquin GLeurquin force-pushed the feat/polars-lag-lead branch from dd1c2c6 to 4ebedf3 Compare March 3, 2025 16:03
@GLeurquin
Copy link
Author

You are right, I forgot about it. I'm using the following code in my project to implement the window in polars.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
polars The polars backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants