fix: include casts for numeric Literals except in comparisons #10933
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10890
I only ran this for duckdb locally, I'm curious to see how this does on all the other backends.
This is a bit of a one-off approach to special-case for the predicate pushdown problem described in project/ibis/issues/9662. eg we only make the special case of
ops.UntypedNumericLiteral
for numbers, but are there other instances where we also want to avoid a cast, so this should be a more generalops.UntypedLiteral
?ibis.dtype_from_backend_string(ibis.literal(12.34, <type>).typeof()) == <type>
is always true (yay!)For myself, a few of the common tests to run