fix: isar crash on resume from app detach #16599
Merged
+14
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenlong-tanwen
force-pushed
the
fix/mobile-isar-crash
branch
from
7df7a79 to
759eaca
Compare
|
Can you help writing a few words on how you tested this to verify the fix? |
Oh, I could reproduce the issue with an emulator, and verified that the above handling fixed the freeze. The basic steps are as follows:
After the fix, the app did not freeze at the splash screen, even for finer log levels. |
alextran1502
approved these changes
Mar 5, 2025
zackpollard
pushed a commit
that referenced
this pull request
Mar 5, 2025
Co-authored-by: shenlong-tanwen <139912620+shalong-tanwen@users.noreply.github.com> Co-authored-by: Alex <alex.tran1502@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16504
Description
Setting log level to anything finer than INFO, results in a large number of log files being emitted which are buffered and flushed to the DB. However, Isar seems to suffer from an issue where if a write transaction is not properly closed on android, it hangs there and crashes when we try to open Isar the next time. Using the back button on android puts the app into detached state, and resuming back to the app will start from
main(), resulting in us opening Isar again and thereby crashing.As a workaround, we ignore all the remaining logs in the buffer when the app is moving into the detached state. However, this should be reverted once we move away from Isar
We used to log messages in the console when on debug mode. This was missed in the refactor and is added now