fix(mobile): .well-known usage #16577
Merged
+14
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zackpollard
approved these changes
Mar 4, 2025
| Uri.parse("$baseUrl/.well-known/immich"), | ||
| headers: headers, | ||
| ) | ||
| .timeout(const Duration(seconds: 5)); |
There was a problem hiding this comment.
I'm not sure about the addition of the timeout here, for a user this could just mean a failure when they have bad network conditions, where waiting a few more seconds might let them connect when connectivity is restored. What was your reasoning for adding this timeout? Aside from this, looks great, this has been a bug for a long time 😅
There was a problem hiding this comment.
If you make a mistake and enter wrong address (e.g. google.com:81), you are waiting until the timeout (60sec?) for the next try. That's the reason for shorter timeout.
In case of bad network condition, it fails anyway on /api/server/ping.
jrasm91
approved these changes
Mar 4, 2025
zackpollard
pushed a commit
that referenced
this pull request
Mar 5, 2025
fix: .well-known Co-authored-by: Alex <alex.tran1502@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16531 caused by #3279.
Custom
/.well-known/immichAPI endpoint is now respected again.