chore(ci/pr-checks): add lint checks #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area: ci
Extension builds preview
|
){kind=icon}
){kind=icon}
|
Not getting the annotations, but it's better than nothing. actions/setup-node#96 |
github-actions
bot
added
area: content
sidvishnoi
removed
area: content
|
The failing lint check is for demonstration only. It's getting fixed in other PR. |
The error needs to be fixed, otherwise merging is blocked. |
There doesn't seem to be any required checks to pass on this repo, just needs an approval. What should be required? @sidvishnoi @raducristianpopa |
|
I think we can require all checks except lint? |
github-actions
bot
added
the
area: content
github-actions
bot
added
area: background
sidvishnoi
removed
area: content
raducristianpopa
approved these changes
Jun 7, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Part of #298
Changes proposed in this pull request
Runs lint, format and typescheck in CI. Doesn't fail entire workflow if lint fails - for now.
Added as separate steps for clearer output.