Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

superServer sub-object of intersystems.servers entry is optional #1490

Merged
merged 2 commits into from
Feb 26, 2025

Conversation

gjsjohnmurray
Copy link
Contributor

This PR fixes #1489

@gjsjohnmurray gjsjohnmurray marked this pull request as ready for review February 25, 2025 19:01
@isc-bsaviano
Copy link
Contributor

@gjsjohnmurray Can you change line 382 in src/api/index.ts to:

outputChannel.appendLine(`+- REQUEST - ${(reqTs ?? new Date()).toLocaleTimeString()} ----------------------------`);

to fix the issue described here? #1489 (comment)

@gjsjohnmurray
Copy link
Contributor Author

@isc-bsaviano done, so ready for your review/approval.

@gjsjohnmurray gjsjohnmurray merged commit 3134001 into intersystems-community:master Feb 26, 2025
5 checks passed
@gjsjohnmurray gjsjohnmurray deleted the fix-1489 branch February 26, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to connect server: Cannot read properties of undefined (reading 'port')
2 participants