Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement custom workspace folder picker #1493

Conversation

isc-bsaviano
Copy link
Contributor

  • More info than built-in showWorkspaceFolderPick().
  • Allows for filtering invalid folders before prompting the user.
  • Will not prompt the user if there is only one folder to pick from.
  • Differentiates between user cancel and nothing to pick from.
Screenshot 2025-02-28 at 9 59 53 AM

Copy link
Contributor

@gjsjohnmurray gjsjohnmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but I haven't tested it.

Now that we are in full control of the quickpick we could add a Close button to the titlebar to give a mouse-only way of dismissing it, since we're retaining the use of ignoreFocusOut: true which means clicking outside it doesn't dismiss it. See microsoft/vscode#99081 for an open issue proposing doing this automatically some day.

However I don't feel strongly that we should do the extra work in this PR, so if you'd prefer not to then let me know and I'll approve it as it stands.

@isc-bsaviano
Copy link
Contributor Author

Thanks for reviewing and linking that issue. I was planning on doing a subsequent "UI normalization" PR that normalizes some language and the use of title instead of placeHolder so I can add this for some of our QuickPicks as part of that PR. I am also ok with removing ignoreFocusOut if we think that's inaccessible.

@gjsjohnmurray gjsjohnmurray self-requested a review March 5, 2025 12:21
@isc-bsaviano isc-bsaviano merged commit b485dde into intersystems-community:master Mar 5, 2025
5 checks passed
@isc-bsaviano isc-bsaviano deleted the custom-wsfolder-picker branch March 5, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants