Clarify ${params} #448
Open
Clarify ${params} #448
+11,438
−7,181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(firestore-stripe-payments): upgraded to the new emulator suite (invertase#400) tests(firestore-stripe-payments): upgraded to the new emulator suite * fix(firestore-stripe-payments): added env stripe key check on test setup * fix(firestore-stripe-payments): added env stripe key check on test setup * formatted code * Remove link to old repo * feat(firestore-stripe-payments): Allow configuring min instances for createCheckoutSession (invertase#375) * feat: Allow configuring min instances for createCheckoutSession * Update firestore-stripe-payments/extension.yaml * Update firestore-stripe-payments/extension.yaml Co-authored-by: Jonathan Steele <83410553+jsteele-stripe@users.noreply.github.com> * chore(firestore-stripe-payments): updated scripts for CI and local testing (invertase#415) * chore(firestore-stripe-payments): updated scripts for ci and local testing * chore(firestore-stripe-payments): added testing typescript configuration, fixes jest warnings in files * fix(firestore-stripe-web-sdk): locked sinon types to 10.0.6 * chore(firestore-stripe-payments): removed obsolete comments * fix(firestore-stripe-payments): `minInstances` parameter expects number * docs(firestore-stripe-payments): Update APIs for restricted key (invertase#411) Prices API replaces the Plans API, per https://stripe.com/docs/api/plans * docs(firestore-stripe-payments): Add extra context to `CREATE_CHECKOUT_SESSION_MIN_INSTANCES` config parameter * fix(firestore-stripe-payments): added subscription payments prices, test and refactor included (invertase#393) * fix(firestore-stripe-payments): added subscription payments prices, tests and refactor included * chore: locked firebase tools workflow to 10.9.2 * added setup emulator for collection helper functions * chore: commiting empty env files * chore: updated ci firebase tools to latest * pinned sinon types at 10.0.6 * feat(firestore-stripe-payments): createPortalLink auth tweaks (invertase#420) Throw 'unauthenticated' code instead of 'failed-precondition' and use optional chaining (supported in Node 14) to avoid redundant check for 'context.auth.uid'. * docs(firestore-stripe-payments): Fix GitHub link to `firestore-stripe-web-sdk` README Fixes invertase#409 * chore: 2022-08-23 release (invertase#422) * [skip ci] Open PR * chore(firestore-stripe-payments): 0.3.0 release * chore: Remove lockfiles from .gitignore (invertase#426) Re-generated `package-lock.json` for each extension, too * chore: 2022-08-24 release (invertase#427) * [skip ci] Open PR * chore(firestore-stripe-invoices): 0.2.1 release * chore(firestore-stripe-payments): 0.3.1 release * fix(firestore-stripe-payments): renamed create checkout min instances config (invertase#428) * chore: Remove lockfiles from .gitignore Re-generated `package-lock.json` for each extension, too * fix(firestore-stripe-payments): renamed create checkout min instances config * fix: added eventchannel check Co-authored-by: Jonathan Steele <jsteele@stripe.com> Co-authored-by: Darren Ackers <ackers86@hotmail.com> Co-authored-by: Darren Ackers <ackers86@hotmail.com> Co-authored-by: CJ Avilla <cjavilla@stripe.com> Co-authored-by: Allen <abierbaum@gmail.com> Co-authored-by: Will Battel <willbattel@gmail.com>
This is tricky because we only want this note to show if they are reading on Github and not in the Extensions > How this Extension Works tab, but thought I would suggest it. I didn't realize these parameters would fill in with my specific project details when I saw them on Github.
|
|
jsteele-stripe
force-pushed
the
master
branch
from
ad40aa0 to
79ac4ee
Compare
|
Hi @joshdance Typically for Firebase Extensions, any documentation that requires a param field - would need to be added to the Extensions.dev documentation is added through the
is there a particularly section of the docs which is in the incorrect file? |
|
Atleast the comment in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is tricky because we only want this note to show if they are reading on Github and not in the Extensions > How this Extension Works tab, but thought I would suggest it.
I didn't realize these parameters would fill in with my specific project details when I saw them on Github.