-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: <ion-segment> @ionChange no longer fires since 8.4.3 ionic-vue update #30177
Comments
I'm having the same issue with @ionChange not being fired but on ion-toggle components, after upgrading to 8.4.3. Reverted to 8.4.2 and it's working. |
Same thing here, @ionChange not fired on ion-segment, @ionInput not fired on ion-input and ion-searchbar |
Same issue, neither @ionInput or @ionChange are firing. I reverted to |
Same here, going back to 8.4.2 fixes this. |
having same issue. Setting to 8.4.2 fixed for me as well. none of the Ion specific events seemed to be firing for me on most components like toggles and searchbars but the revert seemed to fix things |
Is this an issue only on Ionic Vue, or does Ionic React also have this issue? |
@jacobg : I am working on updating several demo apps and have only be affected by this in the Vue based one. Angular and React do not appear to be affected at all. |
@kensodemann Thanks. I'm afraid we may hear an announcement next week that only the React implementation will be maintained moving forward and the others will be dropped, as only React is needed for the maintainer's commercial business model. That would explain why there is this breaking bug in the most recent release for Vue, and yet there is no response or fix for it. |
All indications point to this being fixed and pushed out within a week or two. And Vue, Angular and React will all continue to be supported. As mentioned, the temporary workaround is to downgrade to 8.4.2. |
dynamic value assigning on ion-segment in ionic/angular afaik also broken |
This might be obvious but we just wasted an hour figuring out that the caret (^) in our package.json led to a faulty version. FIXING it to 8.4.2 (no caret a the beginning!) fixed it for us as well - strongly hoping for a fix from ionic soon. |
Thank you for the issue! We're currently investigating this, along with all other related Vue issues introduced in version 8.4.3. |
Issue number: resolves #30206 resolves #30178 resolves #30177 resolves #30175 resolves #30170 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? There have been plenty of issues reported in regards to Vue components failing to propagate events. It seems like when we updated the Vue output target and started to use the provided runtime code from the output target, we have changed the way how event names are computed. Ionic has used a custom wrapper for handling events that would kebab case event names. That is no longer needed and removing it fixes observed issues. Reproduction case working: https://stackblitz.com/edit/vj18czas-wdhzxjom?file=package.json ## What is the new behavior? We have received a fix for this in stenciljs/output-targets#617 which I hope will resolve this issue by updating the dependency. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. --> ## Other information Dev build: `8.4.4-dev.11741193800.14916f6f`
Prerequisites
Ionic Framework Version
v8.x
Current Behavior
In ionic-vue 8.4.2, @ionChange would fire when clicking on each ionic-segment-button. Since 8.4.3, @ionChange no longer fires.
Expected Behavior
@ionChange should fire.
Steps to Reproduce
See instructions above.
Code Reproduction URL
https://ionicframework.com/docs/api/segment#events
Ionic Info
Ionic:
Ionic CLI : 7.2.0
Utility:
cordova-res : not installed globally
native-run : 2.0.1
System:
NodeJS : v18.16.0
npm : 9.5.1
OS : macOS Unknown
Additional Information
No response
The text was updated successfully, but these errors were encountered: