Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(radio-group): add helperText and errorText properties #30222

Merged
merged 27 commits into from
Mar 10, 2025
Merged

feat(radio-group): add helperText and errorText properties #30222

merged 27 commits into from
Mar 10, 2025

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Feb 27, 2025 •
edited
Loading

Issue number: N/A

What is the current behavior?

Radio group does not support helper and error text.

What is the new behavior?

Adds support for helper and error text.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@vercel Vercel
Copy link

vercel bot commented Feb 27, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 10:57pm

@github-actions github-actions bot added package: core @ionic/core package package: angular @ionic/angular package package: vue @ionic/vue package labels Feb 27, 2025
@brandyscarney brandyscarney marked this pull request as ready for review March 4, 2025 16:25
@brandyscarney brandyscarney requested a review from a team as a code owner March 4, 2025 16:25
ShaneK
ShaneK approved these changes Mar 4, 2025
View reviewed changes
Copy link
Member

@ShaneK ShaneK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good, left a couple of comments, but looks good to me 🚀

thetaPC
thetaPC approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor text request

@brandyscarney brandyscarney merged commit 18e26ac into feature-8.5 Mar 10, 2025
49 checks passed
@brandyscarney brandyscarney deleted the ROU-11554 branch March 10, 2025 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thetaPC thetaPC

@ShaneK ShaneK

@christian-bromann christian-bromann

Assignees
No one assigned
Labels
package: angular @ionic/angular package package: core @ionic/core package package: vue @ionic/vue package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brandyscarney @ShaneK @thetaPC