Skip to content

Commit f9968b5

Browse files
committed
Disable ICMP tests on Ubuntu in GitHub.
Ref actions/runner-images#11614; Closes #9
1 parent 359ee74 commit f9968b5

File tree

1 file changed

+23
-2
lines changed

1 file changed

+23
-2
lines changed

conftest.py

Lines changed: 23 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,28 @@ def pywin32_missing():
1919
importlib.import_module('win32service')
2020

2121

22+
def old_ping_exception():
23+
"""
24+
Ping test has different exception on older Pythons.
25+
"""
26+
return sys.version_info < (3, 10)
27+
28+
29+
def broken_actions_runner():
30+
"""
31+
Is unprivileged ICMP unavailable?
32+
33+
Since Dec 2024, GitHub Actions runners no longer seem
34+
to be able to allow unprivileged ICMP.
35+
36+
actions/runner-images#11614
37+
"""
38+
return bool(os.environ.get('GITHUB_ACTIONS')) and (
39+
# Unfortunately, `os.environ['RUNNER_OS']` doesn't work
40+
platform.system() == 'Linux'
41+
)
42+
43+
2244
collect_ignore = (
2345
[
2446
'jaraco/net/devices/linux.py',
@@ -31,10 +53,9 @@ def pywin32_missing():
3153
]
3254
* pywin32_missing()
3355
+ [
34-
# ping test has different exception on older Pythons
3556
'jaraco/net/icmp.py',
3657
]
37-
* (sys.version_info < (3, 10))
58+
* (old_ping_exception() or broken_actions_runner())
3859
)
3960

4061

0 commit comments

Comments
 (0)