Skip to content

issues Search Results · repo:keithamus/invokers-polyfill language:JavaScript

Filter by

20 results
 (77 ms)

20 results

inkeithamus/invokers-polyfill (press backspace or delete to remove)

keithamus/invokers-polyfill
oncommand property missing

This property isn t polyfilled, while it s not a big deal because most people will use addEventListener it does impact some feature detection. Potentially it should be polyfilled as null and documented ...
  • lukewarlow
  • Opened 
    15 days ago
  • #55

keithamus/invokers-polyfill
Use source option for showPopover()

Chrome currently supports the ability to set the source of a showPopover() invocation which enables some extra behaviours. These behaviours are also enabled by command buttons, so the polyfill can get ...
  • lukewarlow
  • 1
  • Opened 
    20 days ago
  • #52

keithamus/invokers-polyfill
Document lack of aria-expanded support?

This polyfill doesn t set aria-expanded when the built-in would be. This should be fixed or documented.
  • lukewarlow
  • Opened 
    on Feb 7
  • #51

keithamus/invokers-polyfill
Inputs shouldn't be supported

Input buttons should no longer be supported
  • lukewarlow
  • Opened 
    on Feb 5
  • #50

keithamus/invokers-polyfill
This only intends to covers Invoker Commands, not interest invokers, right?

This only intends to covers Invoker Commands, not interest invokers, right?
  • SilentImp
  • 1
  • Opened 
    on Dec 11, 2024
  • #49

keithamus/invokers-polyfill
Minified build out-of-date

The current minified version of the build is 5 commits out-of-date and broken in Canary. Using the non-minified version seems to work fine, so it appears that it purely needs regenerating.
  • ryantownsend
  • 2
  • Opened 
    on Oct 7, 2024
  • #46

keithamus/invokers-polyfill
Enable Bubbling for CommandEvent

I d like to create a --toggle-modal command. Currently, CommandEvent doesn t bubble, requiring individual listeners for each dialog. Enabling bubbling would allow for a single, global listener. document.addEventListener( ...
  • davidmerrique
  • 1
  • Opened 
    on Jul 31, 2024
  • #45

keithamus/invokers-polyfill
Forcing custom commands to have `--` prefix breaks polyfilling native commands

I m not sure whether this is intended to be enforced by the spec / browser implementation, but having this line: https://github.com/keithamus/invokers-polyfill/blob/15a020a22fee2000efc93fbf41d3804f7fa7c485/invoker.js#L282 ...
  • ryantownsend
  • 6
  • Opened 
    on Jul 31, 2024
  • #44

keithamus/invokers-polyfill
Couple of minor mistakes

Sorry I don t have time to raise a PR right now but I think this line: https://github.com/keithamus/invokers-polyfill/blob/15a020a22fee2000efc93fbf41d3804f7fa7c485/invoker.js#L28 Should be checking e.type ...
  • ryantownsend
  • Opened 
    on Jul 31, 2024
  • #43

keithamus/invokers-polyfill
Remove interesttarget code

I think it s worth removing all code related to interest targets from the example and repository. To make it clear that s separate from the initial invokers work.
  • lukewarlow
  • Opened 
    on May 6, 2024
  • #40
Issue origami icon

Learn how you can use GitHub Issues to plan and track your work.

Save views for sprints, backlogs, teams, or releases. Rank, sort, and filter issues to suit the occasion. The possibilities are endless.Learn more about GitHub Issues
ProTip! 
Press the
/
key to activate the search input again and adjust your query.
Issue origami icon

Learn how you can use GitHub Issues to plan and track your work.

Save views for sprints, backlogs, teams, or releases. Rank, sort, and filter issues to suit the occasion. The possibilities are endless.Learn more about GitHub Issues
ProTip! 
Press the
/
key to activate the search input again and adjust your query.
Issue search results · GitHub