KTOR-7048: Support parameters in Resources url inside the path #4059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e5l
approved these changes
May 31, 2024
|
It looks like the resource tests are failing. Could you check? |
|
Can you rerun the CI? |
|
Sure, sorry for the delay |
|
Seems there's a test failure in |
|
@hfhbd, would you like to rebase this PR and fix tests? |
|
@osipxd Yes, will do it, but I also noticed the failing test requires a little rework because I didn't handle the test case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Client, Server, shared resources
Motivation
KTOR-7048: Resources url builder does not replaces parameters inside the path
Solution
Use a regex to replace the placeholder url with the actual values