-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KTOR-8223 Move existing build logic to precompiled script plugins #4577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3444354
to
5287812
Compare
5287812
to
5727952
Compare
1 task
2460e90
to
16b7b0b
Compare
16b7b0b
to
4478870
Compare
4478870
to
c679b61
Compare
c679b61
to
e4ecd0d
Compare
osipxd
commented
Feb 21, 2025
e4ecd0d
to
a0171b0
Compare
a0171b0
to
ab3d60d
Compare
ab3d60d
to
bfcb906
Compare
bjhham
approved these changes
Feb 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Infrastructure
Motivation
KTOR-8223 Move existing build logic to precompiled script plugins
Solution
Move pieces of build configuration from
buildSrc
intobuild-logic
and make them precompiled script plugins.Publishing logic is to be moved in a separate task (KTOR-8222).
It's better to review commit-by-commit.
Previous steps: