Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper toString() implementation for MutableOriginConnectionPoint #4685

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

DRSchlaubi
Copy link
Contributor

Subsystem
Server

Motivation
KTOR-8209 MutableOriginConnectionPoint has no toString()

Solution
Delegate toString() to the delegate property

Copy link
Member

@e5l e5l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @DRSchlaubi, thanks for the PR. LGTM

@e5l e5l enabled auto-merge (squash) February 22, 2025 08:46
@DRSchlaubi
Copy link
Contributor Author

Is there anything i need to fix apart from an api dump

auto-merge was automatically disabled February 22, 2025 20:57

Head branch was pushed to by a user without write access

@osipxd osipxd enabled auto-merge (squash) February 24, 2025 11:13
@osipxd osipxd disabled auto-merge February 24, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants