KTOR-7298: Load modules dynamically only if development mode is enabled #4715
+95
−43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Server
Motivation
KTOR-7298 Android: "Array has more than one element" error when starting a server with release build
Solution
There were several problems with modules loading when code was optimized by R8 or ProGuard:
Function<*>.methodName()
could throwKotlinReflectionInternalError
for obfuscated methodsclazz.declaredConstructors.single()
inexecuteModuleFunction
could throwIllegalArgumentException
because the class could has either zero or more than one constructor (needs to be investigated further)Fixed all of these issues in separate commits so it's better to review commit-by-commit.