Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-approve and auto-merge renovate PRs #4723

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

osipxd
Copy link
Member

@osipxd osipxd commented Mar 4, 2025

Subsystem
Infrastructure

Motivation

  1. Make it possible to merge PRs without review (for "Ship" PRs from Ship/Show/Ask)
  2. Merge renovate PRs automatically when possible

Solution
Automatically approve PRs from Renovate or having label "ship!".
Enable automerge for patch updates and for test/infrastucture dependencies.

(Added tag "ship" to this PR as a demo)

@osipxd osipxd self-assigned this Mar 4, 2025
GH_REPO: ${{ github.repository_owner }}/${{ github.event.repository.name }}

- name: Enable auto-merge
if: contains(github.event.pull_request.labels.*.name, '👍 ship!')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For renovate PRs auto-merge is managed by renovate.json

},
{
"description": "Automerge patch releases",
"matchUpdateTypes": ["patch"],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also merge minor releases automatically?

@osipxd osipxd added the 👍 ship! This pull request can be shipped bypassing review. Read about "Ship/Show/Ask" strategy for more info label Mar 4, 2025
@osipxd osipxd requested a review from bjhham March 4, 2025 11:47
@osipxd osipxd changed the title Auto-approve and auto-merger the most of renovate updates Auto-approve and auto-merge renovate updates Mar 4, 2025
@osipxd osipxd changed the title Auto-approve and auto-merge renovate updates Auto-approve and auto-merge renovate PRs Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👍 ship! This pull request can be shipped bypassing review. Read about "Ship/Show/Ask" strategy for more info
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant