Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Direct Service Return (DSR) and overlay networking in Windows kube-proxy #5100

Open
2 of 5 tasks
marosset opened this issue Jan 28, 2025 · 15 comments
Open
2 of 5 tasks
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/network Categorizes an issue or PR as relevant to SIG Network. sig/windows Categorizes an issue or PR as relevant to SIG Windows. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Milestone

Comments

@marosset
Copy link
Contributor

marosset commented Jan 28, 2025

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 28, 2025
@marosset
Copy link
Contributor Author

/sig windows networking
/stage beta
/milestone v1.33

@k8s-ci-robot k8s-ci-robot added the stage/beta Denotes an issue tracking an enhancement targeted for Beta status label Jan 28, 2025
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Jan 28, 2025
@k8s-ci-robot
Copy link
Contributor

@marosset: The label(s) sig/networking cannot be applied, because the repository doesn't have them.

In response to this:

/sig windows networking
/stage beta
/milestone v1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 28, 2025
@marosset
Copy link
Contributor Author

WinDSR and WinOverlay feature gates were added in K8s v1.14 and were introduced without a KEP.
Both of these features gates are stable and used in many production environments.
This enhancement will add a 'retroactive' KEP for DSR and Overlay support for Windows nodes documenting what the features enable and will be used to move the feature gates to stable in upcoming releases.

@marosset marosset added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Jan 28, 2025
@marosset marosset self-assigned this Jan 28, 2025
@marosset
Copy link
Contributor Author

marosset commented Feb 3, 2025

/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Feb 3, 2025
@jenshu
Copy link

jenshu commented Feb 4, 2025

Hello @marosset 👋, v1.33 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025.

This enhancement is targeting stage beta for v1.33 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.33.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 6th February 2025 so that the PRR team has enough time to review your KEP.

For this KEP, we would just need to update the following:

  • I see that you have a PR open with some of these updates. Please also make sure to add an approver for beta in the PRR file.

The status of this enhancement is marked as At risk for enhancements freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@jenshu jenshu moved this to At risk for enhancements freeze in 1.33 Enhancements Tracking Feb 4, 2025
@sftim
Copy link
Contributor

sftim commented Feb 10, 2025

Even though this is retroactive, the KEP title should explain the feature more than the retroactiveness. That makes https://www.kubernetes.dev/resources/keps/ most useful to readers.

@dipesh-rawat
Copy link
Member

Hi @marosset 👋, 1.33 Enhancements team here,

Just a quick friendly reminder as we approach the enhancements freeze later this week, at 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025.

The current status of this enhancement is marked as At risk for enhancement freeze. There are a few requirements mentioned in the comment #5100 (comment) that still need to be completed.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@hacktivist123
Copy link

Hello @marosset 👋, v1.33 Docs Shadow here.

Does this enhancement work planned for v1.33 require any new docs or modification to existing docs?
If so, please follow the steps here to open a PR against dev-1.33 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 27th February 2025 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@marosset
Copy link
Contributor Author

Even though this is retroactive, the KEP title should explain the feature more than the retroactiveness. That makes https://www.kubernetes.dev/resources/keps/ most useful to readers.

@sftim - Is this comment in regards to the issue title?
I'm just confirming where all to update.

@marosset marosset changed the title Retroactive KEP for WinDSR and WinOverlay feature-gates Support for Direct Service Return (DSR) and overlay networking in Windows kube-proxy Feb 12, 2025
@sftim
Copy link
Contributor

sftim commented Feb 12, 2025

(yes, issue / KEP title)

@jenshu
Copy link

jenshu commented Feb 13, 2025

Hello @marosset 👋, v1.33 Enhancements team here.

With all the requirements fulfilled, this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀

@jenshu jenshu moved this from At risk for enhancements freeze to Tracked for enhancements freeze in 1.33 Enhancements Tracking Feb 13, 2025
@jenshu jenshu added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Feb 13, 2025
@marosset
Copy link
Contributor Author

Hello @marosset 👋, v1.33 Docs Shadow here.

Does this enhancement work planned for v1.33 require any new docs or modification to existing docs? If so, please follow the steps here to open a PR against dev-1.33 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 27th February 2025 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

Added kubernetes/website#49904 as a placeholder
thanks @hacktivist123

@rytswd
Copy link
Member

rytswd commented Mar 1, 2025

Hi @marosset 👋 -- this is Ryota (@rytswd) from the 1.33 Communications Team!

For the 1.33 release, we are currently in the process of collecting and curating a list of potential feature blogs, and we'd love for you to consider writing one for your enhancement!

As you may be aware, feature blogs are a great way to communicate to users about features which fall into (but not limited to) the following categories:

  • This introduces some breaking change(s)
  • This has significant impacts and/or implications to users
  • ...Or this is a long-awaited feature, which would go a long way to cover the journey more in detail 🎉

To opt in to write a feature blog, could you please let us know and open a "Feature Blog placeholder PR" (which can be only a skeleton at first) against the website repository by Wednesday, 5th March, 2025? For more information about writing a blog, please find the blog contribution guidelines 📚

Tip

Some timeline to keep in mind:

  • 02:00 UTC Wednesday, 5th March, 2025: Feature blog PR freeze
  • Monday, 7th April, 2025: Feature blogs ready for review
  • You can find more in the release document

Note

In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

@sn3hay
Copy link

sn3hay commented Mar 3, 2025

Hi @marosset 👋, this is Sneha, from the 1.33 Communications Team here again!

This is a gentle reminder for the feature blog deadline mentioned above, which is 02:00 UTC Wednesday, 5th March, 2025. To opt in, please let us know and open a Feature Blog placeholder PR against [k/website](https://github.com/kubernetes/website) by the deadline. If you have any questions, please feel free to reach out to us!

Tip

Some timeline to keep in mind:

Note

In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

@jenshu
Copy link

jenshu commented Mar 4, 2025

Hey again @marosset 👋, v1.33 Enhancements team here.

Just checking in as we approach code freeze at 02:00 UTC Friday 21st March 2025 / 19:00 PDT Thursday 20th March 2025.

As this is a retroactive KEP, can you confirm whether there are any new code changes that need to be merged into k/k for this release, and if so, can you please update the issue description above with the PR links?

In the meantime I will mark this as At risk for code freeze. Thanks!

@jenshu jenshu moved this from Tracked for enhancements freeze to At risk for code freeze in 1.33 Enhancements Tracking Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/network Categorizes an issue or PR as relevant to SIG Network. sig/windows Categorizes an issue or PR as relevant to SIG Windows. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Projects
Status: At risk for code freeze
Development

No branches or pull requests

8 participants