Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split L3 Cache Topology Awareness in CPU Manager #5109

Open
4 of 8 tasks
ajcaldelas opened this issue Jan 30, 2025 · 20 comments
Open
4 of 8 tasks

Split L3 Cache Topology Awareness in CPU Manager #5109

ajcaldelas opened this issue Jan 30, 2025 · 20 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Milestone

Comments

@ajcaldelas
Copy link
Contributor

ajcaldelas commented Jan 30, 2025

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 30, 2025
@ajcaldelas
Copy link
Contributor Author

ajcaldelas commented Jan 30, 2025

/sig node
/assign @ajcaldelas @wongchar

@k8s-ci-robot
Copy link
Contributor

@ajcaldelas: The label(s) sig/sig-node cannot be applied, because the repository doesn't have them.

In response to this:

/sig sig-node
/assign @ajcaldelas @wongchar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

@ajcaldelas: GitHub didn't allow me to assign the following users: wongchar.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/sig sig-node
/assign @ajcaldelas @wongchar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kannon92
Copy link
Contributor

I don't understand why #4800 is not sufficient.

Is this a duplicate?

@ajcaldelas
Copy link
Contributor Author

I don't understand why #4800 is not sufficient.

Is this a duplicate?

From what I understand since the original author is no longer contributing atm, we need to create a new issue and backlink the original issue. This is not a duplicate in that sense, I mentioned a reference to it in the issue description.

@ffromani if you could chime in that would be appreciated.

@ffromani
Copy link
Contributor

I don't understand why #4800 is not sufficient.

Is this a duplicate?

this is another case on which we have to adopt an issue because AFAIU the original contributor is no longer active and someone else is taking over.
The current approach (which I suggested indeed offline) seems the less bad to me but I'm open to suggestions.

@ffromani
Copy link
Contributor

started a thread on sig-arch to see if we can improve this take-over process https://kubernetes.slack.com/archives/C5P3FE08M/p1738311284411229

@ffromani
Copy link
Contributor

/sig node

please review examples of other takeovers. Examples (there are others):
#3570
#3743

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 31, 2025
@kannon92
Copy link
Contributor

Taking over this is fine. It wasn't clear in the description.

Can you make sure the KEP template follows others? The markdown seems off.

@ajcaldelas
Copy link
Contributor Author

Can you be specific? I directly copied it from the repo so I'm not sure what's off about it

@kannon92
Copy link
Contributor

kannon92 commented Jan 31, 2025

#4800 looks different than yours.

It is the markdown formatting that differs not the content but let's try to be consistent.

@wongchar
Copy link
Contributor

/assign @wongchar

@haircommander
Copy link
Contributor

/label lead-opted-in
/milestone v1.33

note: PRR freeze is tomorrow! you need to have a KEP update for this opened before then. Thanks!

@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Feb 5, 2025
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Feb 5, 2025
@jenshu
Copy link

jenshu commented Feb 7, 2025

Hello @wongchar, @ajcaldelas 👋, v1.33 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025.

This enhancement is targeting stage alpha for v1.33 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.33.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 6th February 2025 so that the PRR team has enough time to review your KEP.

For this KEP, we would just need to update the following:

  • in the kep.yaml, the latest-milestone should be updated to v1.33 (I see that you have a PR open that will take care of that)

The status of this enhancement is marked as At risk for enhancements freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@jenshu jenshu moved this to At risk for enhancements freeze in 1.33 Enhancements Tracking Feb 7, 2025
@jenshu jenshu added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Feb 7, 2025
@dipesh-rawat
Copy link
Member

Hi @wongchar, @ajcaldelas 👋, 1.33 Enhancements team here,

Just a quick friendly reminder as we approach the enhancements freeze later this week, at 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025.

The current status of this enhancement is marked as At risk for enhancement freeze. There are a few requirements mentioned in the comment #5109 (comment) that still need to be completed.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@haircommander haircommander moved this from Proposed for consideration to Tracked in SIG Node 1.33 KEPs planning Feb 12, 2025
@jenshu
Copy link

jenshu commented Feb 13, 2025

Hello @wongchar, @ajcaldelas 👋, v1.33 Enhancements team here.

With all the requirements fulfilled, this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀

@jenshu jenshu moved this from At risk for enhancements freeze to Tracked for enhancements freeze in 1.33 Enhancements Tracking Feb 13, 2025
@jenshu jenshu added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Feb 13, 2025
@wongchar
Copy link
Contributor

No changes to official Kubernetes documentation for v1.33 release but plan to add a blog post in the future

@aibarbetta
Copy link
Member

Hi @wongchar, @ajcaldelas 👋 -- this is Agustina (@aibarbetta) from the 1.33 Communications Team!

For the 1.33 release, we are currently in the process of collecting and curating a list of potential feature blogs, and we'd love for you to consider writing one for your enhancement!

As you may be aware, feature blogs are a great way to communicate to users about features which fall into (but not limited to) the following categories:

  • This introduces some breaking change(s)
  • This has significant impacts and/or implications to users
  • ...Or this is a long-awaited feature, which would go a long way to cover the journey more in detail 🎉

To opt in to write a feature blog, could you please let us know and open a "Feature Blog placeholder PR" (which can be only a skeleton at first) against the website repository by Wednesday, 5th March, 2025? For more information about writing a blog, please find the blog contribution guidelines 📚

Tip

Some timeline to keep in mind:

  • 02:00 UTC Wednesday, 5th March, 2025: Feature blog PR freeze
  • Monday, 7th April, 2025: Feature blogs ready for review
  • You can find more in the release document

Note

In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

@aibarbetta
Copy link
Member

Hi @wongchar, @ajcaldelas 👋, 1.33 Communications Team here again!

This is a gentle reminder for the feature blog deadline mentioned above, which is 02:00 UTC Wednesday, 5th March, 2025. To opt in, please let us know and open a Feature Blog placeholder PR against k/website by the deadline. If you have any questions, please feel free to reach out to us!

Tip

Some timeline to keep in mind:

  • 02:00 UTC Wednesday, 5th March, 2025: Feature blog PR freeze
  • Monday, 7th April, 2025: Feature blogs ready for review
  • You can find more in the release document

Note

In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

@jenshu
Copy link

jenshu commented Mar 4, 2025

Hey again @wongchar @ajcaldelas 👋, v1.33 Enhancements team here.

Just checking in as we approach code freeze at 02:00 UTC Friday 21st March 2025 / 19:00 PDT Thursday 20th March 2025.

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

Per the issue description, these are all of the implementation (code-related) PRs for 1.33, some of which are not merged yet:

Please let me know (and keep the issue description updated) if there are any other PRs in k/k that we should track for this KEP, so that we can maintain accurate status.

If you anticipate missing code freeze, you can file an exception request in advance.

The status of this enhancement is marked as At risk for code freeze.

@jenshu jenshu moved this from Tracked for enhancements freeze to At risk for code freeze in 1.33 Enhancements Tracking Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Projects
Status: At risk for code freeze
Status: Tracked
Development

No branches or pull requests

9 participants