Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-4020: Replace StorageversionAPI with AggregatedDiscovery to fetch served resources by peer apiservers #5113

Merged
merged 1 commit into from
Mar 5, 2025
Merged

KEP-4020: Replace StorageversionAPI with AggregatedDiscovery to fetch served resources by peer apiservers #5113

merged 1 commit into from
Mar 5, 2025

Conversation

richabanker
Copy link
Contributor

@richabanker richabanker commented Jan 31, 2025 •
edited
Loading

  • One-line PR description: Replace StorageversionAPI with AggregatedDisovery to fetch served resources by peer apiservers. Also some formatting changes.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 31, 2025
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 31, 2025
Jefftree
Jefftree reviewed Feb 3, 2025
View reviewed changes
keps/sig-api-machinery/4020-unknown-version-interoperability-proxy/README.md Outdated

5. If the proxy call fails for network issues or any reason, we serve 503 with error `Error while proxying request to destination apiserver`

6. We will also add a poststarthook for the apiserver to ensure that it does not start serving requests until we are done creating/updating SV objects
6. We will also add a poststarthook for the apiserver to ensure that it does not start serving requests until we have populated both Local Discovery and Remote Discovery caches.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on local discovery poststarthook. Remote discovery could be considerably slower? Do we really want to block on those as well? When working on aggregated discovery, we specifically did not block startup on remote apiservices (which is slightly different than remote apiservers) to avoid adding excessive startup time.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, the other alternative is serve 503 if the peer-agg-discovery cache hasnt yet synced. I guess we could do that if this(adding delay in apiserver bootstrap) is a major concern ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified to say that the poststarthook will block traffic-serving until the local discovery cache is full and the apiserver identity informer is synced

@richabanker richabanker changed the title KEP-4020: Add beta criteria for Mixed Version Proxy [WIP] KEP-4020: Add beta criteria for Mixed Version Proxy Feb 4, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 4, 2025
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 5, 2025
@richabanker richabanker changed the title [WIP] KEP-4020: Add beta criteria for Mixed Version Proxy [WIP] KEP-4020: Replace StorageversionAPI with AggregatedDisovery to fetch served resources by peer apiservers Feb 5, 2025
@richabanker richabanker changed the title [WIP] KEP-4020: Replace StorageversionAPI with AggregatedDisovery to fetch served resources by peer apiservers [WIP] KEP-4020: Replace StorageversionAPI with AggregatedDiscovery to fetch served resources by peer apiservers Feb 5, 2025
@richabanker richabanker force-pushed the mvp-update branch 4 times, most recently from 9bef8fe to a173ee4 Compare February 5, 2025 21:28
@richabanker richabanker changed the title [WIP] KEP-4020: Replace StorageversionAPI with AggregatedDiscovery to fetch served resources by peer apiservers KEP-4020: Replace StorageversionAPI with AggregatedDiscovery to fetch served resources by peer apiservers Feb 5, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 5, 2025
@richabanker richabanker force-pushed the mvp-update branch 2 times, most recently from 62a3804 to e3e1740 Compare February 5, 2025 22:10
@richabanker richabanker mentioned this pull request Feb 11, 2025
Draft
@richabanker richabanker mentioned this pull request Feb 24, 2025
Merged
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 25, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 26, 2025
@richabanker richabanker force-pushed the mvp-update branch 3 times, most recently from b459718 to b46e339 Compare February 26, 2025 22:51
@richabanker richabanker force-pushed the mvp-update branch 5 times, most recently from 036d4d0 to 474e383 Compare March 3, 2025 20:57
Jefftree
Jefftree reviewed Mar 4, 2025
View reviewed changes
Copy link
Member

@Jefftree Jefftree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two comments otherwise LGTM

Jefftree
Jefftree reviewed Mar 4, 2025
View reviewed changes
Copy link
Member

@Jefftree Jefftree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpbetz
Copy link
Contributor

jpbetz commented Mar 5, 2025

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpbetz, richabanker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2025
@k8s-ci-robot k8s-ci-robot merged commit c5123d5 into kubernetes:master Mar 5, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jefftree Jefftree

@apelisse apelisse

@deads2k deads2k

Assignees

@jpbetz jpbetz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.33
Development

Successfully merging this pull request may close these issues.
4 participants
@richabanker @jpbetz @k8s-ci-robot @Jefftree