[WIP]KEP-4958: CSI Sidecars All in one #5153
Conversation
mowangdk
commented
Feb 7, 2025
mowangdk
commented
- One-line PR description: To combine the source code of the CSI sidecars in a monorepo.
- Issue link: CSI Sidecars All in one #4958
- Other comments:
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mowangdk The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
kind/kep
|
|
||
| We designed the AIO repo's RBAC policy to mirror that of individual repos, where each controller maintains its own policy. Driver maintainers should apply proper RBAC when enabling specific controllers in AIO | ||
|
|
||
| > We plan to combine informer caches of different controllers in the future, which will involve updating some RBAC policies, to be addressed in a subsequent KEP |
There was a problem hiding this comment.
We could have a pointer to the milestone that talks about the future milestone.
|
|
||
| #### Monorepo component | ||
|
|
||
| poc version: https://github.com/mauriciopoppe/csi-sidecars |
There was a problem hiding this comment.
This should be a link to the nested locations in the monorepo source code e.g. https://github.com/mauriciopoppe/csi-sidecars/tree/main/pkg/attacher
| poc version: https://github.com/mauriciopoppe/csi-sidecars | ||
|
|
||
|
|
||
| #### Deployment Workflow Definition |
| proposal will be implemented, this is the place to discuss them. | ||
| --> | ||
|
|
||
|  |
There was a problem hiding this comment.
This diagram complements the graph that shows the monorepo and individual repo's timelines so it's good to have both.
Please move this diagram to its own section below "Development Workflow Definition" that shows how development is going to look like in terms of workstreams.
| ##### AIO MonoRepo state definition | ||
|
|
||
| - inner-verified: Current state of AIO MonoRepo | ||
| - production-verified: Available for production environments, a Cloud vendor that's using it in its production environment. |
There was a problem hiding this comment.
There can be a cross reference to the milestones listed below e.g.
- by the start of the production verified we'll have Y number of sidecars in the monorepo.
- by the end of production verified we'll reach milestone X and have Y number of sidecars working through CSI hostpath
| ##### AIO MonoRepo state definition | ||
|
|
||
| - inner-verified: Current state of AIO MonoRepo | ||
| - production-verified: Available for production environments, a Cloud vendor that's using it in its production environment. |
There was a problem hiding this comment.
During this state we expect CSI Driver authors to start integrating their CSI Drivers with the monorepo artifacts. We also mentioned that this state could be "beta"
| - (future) archive it but not at the same time as the deprecation time, this is a terminal state so we can't undo it | ||
|
|
||
|
|
||
|  |
There was a problem hiding this comment.
Feature freeze on the individual repos should start after the monorepo reaches GA.
|
@mowangdk: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
