Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-5008: Update KEP to be about moving headlamp #5181

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

KEP-5008: Update KEP to be about moving headlamp #5181

wants to merge 8 commits into from

Conversation

joaquimrocha
Copy link
Contributor

  • One-line PR description: Update KEP to be about moving Headlamp under the SIG UI
  • Other comments: This comes after the KEP was merged as provisional and following some discussion around the proposal.

@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/ui Categorizes an issue or PR as relevant to SIG UI. labels Feb 20, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @joaquimrocha. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 20, 2025
@aojea
Copy link
Member

aojea commented Feb 20, 2025

/ok-to-test
/assign @soltysh
/lgtm

Thanks

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 20, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2025
@joaquimrocha joaquimrocha marked this pull request as draft February 20, 2025 17:31
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 20, 2025
@joaquimrocha
Copy link
Contributor Author

Moved to draft while I update a couple of things.

soltysh
soltysh reviewed Feb 21, 2025
View reviewed changes
@joaquimrocha joaquimrocha force-pushed the update-5008-kep-to-be-about-moving-headlamp branch from 30ec4f7 to e82ba2a Compare February 24, 2025 17:13
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 24, 2025
@joaquimrocha
kep-5008: Add empty participating SIG
cf09c88 
Signed-off-by: Joaquim Rocha <joaquim.rocha@microsoft.com>
@joaquimrocha
kep-5008: Change proposal to be about moving Healdamp under SIG UI
23fdc5c 
Signed-off-by: Joaquim Rocha <joaquim.rocha@microsoft.com>
@joaquimrocha
kep-5008: Add reviewers and approvers
67148c9 
Signed-off-by: Joaquim Rocha <joaquim.rocha@microsoft.com>
@joaquimrocha
kep-5008: Remove milestone related KEP indicators
608fcfb 
Signed-off-by: Joaquim Rocha <joaquim.rocha@microsoft.com>
@joaquimrocha
kep-5008: Rename KEP directory name to show Headlamp
ae8f701 
Signed-off-by: Joaquim Rocha <joaquim.rocha@microsoft.com>
@joaquimrocha joaquimrocha force-pushed the update-5008-kep-to-be-about-moving-headlamp branch from e82ba2a to ae8f701 Compare February 24, 2025 17:17
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 24, 2025
@joaquimrocha joaquimrocha marked this pull request as ready for review February 24, 2025 17:18
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 24, 2025
@joaquimrocha
Copy link
Contributor Author

@aojea , @soltysh , @floreks . Seems like the tests are passing after those minimal changes I added on Monday. Let me know if there is anything else needing my attention here. Thank you for your help.

@floreks
Copy link
Member

floreks commented Feb 27, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2025
@soltysh
Copy link
Contributor

soltysh commented Mar 7, 2025

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Mar 7, 2025
soltysh
soltysh reviewed Mar 7, 2025
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments to address and then it's good to merge.

@joaquimrocha
kep-5008: Add Github issue related to the progress of moving Headlamp
a557b35 
Signed-off-by: Joaquim Rocha <joaquim.rocha@microsoft.com>
@joaquimrocha
kep-5008: Make it clear we are moving only the Headlamp repo.
6cd21dc 
Signed-off-by: Joaquim Rocha <joaquim.rocha@microsoft.com>
@joaquimrocha
kep-5008: Remove note about the progress of the minikube plugin
8e046ad 
Signed-off-by: Joaquim Rocha <joaquim.rocha@microsoft.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2025
@joaquimrocha
Copy link
Contributor Author

Thanks @soltysh . Ready to review again.

soltysh
soltysh approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, but that's something you can fix at any time
/lgtm
/approve

you'll likely need someone from sig-ui to approve this PR

keps/sig-ui/5008-headlamp/README.md
@@ -158,6 +158,13 @@ projects to integrate with and build upon. Essentially, we think Headlamps'
ability to be adapted and used across many scenarios allows it to serve as a
central hub for the CNCF community and projects.

Given the adotion of Headlamp as a tool or as a base building block for other
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Given the adotion of Headlamp as a tool or as a base building block for other
Given the adoption of Headlamp as a tool or as a base building block for other

keps/sig-ui/5008-headlamp/README.md
the plugins that maintained by Headlamp's core developers, and the website of
the project. This proposal entails only the move of the headlamp-k8s/headlamp
repository under the kubernetes-sig organization. Other repositories may be
proposed to be moved as well at a later stage.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: joaquimrocha, soltysh
Once this PR has been reviewed and has the lgtm label, please ask for approval from floreks. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh

@floreks floreks

@shu-mutou shu-mutou

Assignees

@soltysh soltysh

@floreks floreks

@aojea aojea

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/ui Categorizes an issue or PR as relevant to SIG UI. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joaquimrocha @k8s-ci-robot @aojea @floreks @soltysh