Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to turn off reranker in workflow with external knowledge added #15214

Closed
4 of 5 tasks
LHANTAEK opened this issue Mar 7, 2025 · 4 comments · Fixed by #15235
Closed
4 of 5 tasks

Unable to turn off reranker in workflow with external knowledge added #15214

LHANTAEK opened this issue Mar 7, 2025 · 4 comments · Fixed by #15235
Labels
🐞 bug Something isn't working cloud When the version is cloud and it is a bug report good first issue Good first issue for newcomers

Comments

@LHANTAEK
Copy link
Contributor

LHANTAEK commented Mar 7, 2025

Self Checks

  • This is only for bug report, if you would like to ask a question, please head to Discussions.
  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report (我已阅读并同意 Language Policy).
  • [FOR CHINESE USERS] 请务必使用英文提交 Issue,否则会被关闭。谢谢!:)
  • Please do not modify this template :) and fill in all the required fields.

Dify version

1.0.0

Cloud or Self Hosted

Cloud

Steps to reproduce

After adding external knowledge to my workflow, I received a prompt indicating that a reranker needed to be configured, so I applied the Cohere model. However, when I tried turning the reranker off, it continuously remained activated. Is the use of a reranker mandatory when utilizing external knowledge, or could this be a bug?

✔️ Expected Behavior

No response

❌ Actual Behavior

No response

Copy link

dosubot bot commented Mar 7, 2025

Hey @LHANTAEK! 👋 I'm here to help you with any bugs, questions, or contributions you have for Dify. I'm a bot designed to assist you while you wait for a human maintainer. Let's tackle this together!

The use of a reranker is not mandatory when utilizing external knowledge in a workflow. The issue you're experiencing, where you are unable to turn off the reranker, was a bug in Dify version 0.15.3. However, this bug has been fixed in a recent update. Since you are using version 1.0.0, the reranker should be disabled by default unless explicitly enabled. If you are still facing this issue, it might be worth checking your configuration settings or ensuring that your update to version 1.0.0 was successful [1].

To continue talking to Dosu, mention @dosu.


Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Bug Report | Other

@dosubot dosubot bot added cloud When the version is cloud and it is a bug report 🌊 feat:workflow Workflow related stuff. 🐞 bug Something isn't working labels Mar 7, 2025
@crazywoola crazywoola added good first issue Good first issue for newcomers and removed 🌊 feat:workflow Workflow related stuff. labels Mar 7, 2025
@LHANTAEK
Copy link
Contributor Author

LHANTAEK commented Mar 7, 2025

@dosu

I have already checked previous issues related to this, but the reranker still cannot be turned off in the current workflow with external knowledge added. Could you please advise on how to resolve this issue?

Copy link

dosubot bot commented Mar 7, 2025

To resolve the issue of being unable to turn off the reranker in a workflow with external knowledge added, ensure that the currentRerankModel is not required when disabling the reranker. The code allows disabling the reranker without any issue if currentRerankModel is not present. Additionally, check that the multiple_retrieval_config is correctly set in the nodeDefault configuration, with reranking_enable set to false by default [1][2].

If the problem persists, verify that there are no other conditions or external factors affecting this logic. Conditions such as allEconomic, mixtureHighQualityAndEconomic, inconsistentEmbeddingModel, allExternal, mixtureInternalAndExternal, and allHighQuality combined with !inconsistentEmbeddingModel and allInternal can influence the reranker's behavior [3].

To continue talking to Dosu, mention @dosu.


Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Bug Report | Other

@LHANTAEK
Copy link
Contributor Author

LHANTAEK commented Mar 7, 2025

@crazywoola Hi,

On the web interface, even after setting the reranker to "OFF," it continues to automatically revert to "ON." However, after downloading the DSL file, manually changing reranking_enable: true to false, and re-uploading this modified DSL, I confirmed that publishing is possible with the reranker set to "OFF." What might be causing this issue? Why doesn't the reranker remain "OFF" through the web interface?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working cloud When the version is cloud and it is a bug report good first issue Good first issue for newcomers
Projects
None yet
2 participants