Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Add "Disable synchronisation" to Joplin Cloud prompt message #11696 #11705

Merged
merged 5 commits into from
Mar 8, 2025

Conversation

Vortrix5
Copy link
Contributor

Screenshot 2025-01-22 at 3 38 59 PM

Copy link
Contributor

github-actions bot commented Jan 22, 2025

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@Vortrix5
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Jan 22, 2025
@Vortrix5
Copy link
Contributor Author

@laurent22 How should we proceed with the merging? This is my first contribution and I still unsure on what should be happening next.

@Vortrix5 Vortrix5 requested a review from laurent22 February 9, 2025 09:27
@laurent22
Copy link
Owner

laurent22 commented Feb 9, 2025

Still not done. You mark my comments as resolved but you don't even read them properly.

@Vortrix5
Copy link
Contributor Author

Still not done. You mark my comments as resolved but you don't even read them properly.

Apologies for that, should be done now.

@Vortrix5
Copy link
Contributor Author

Is this PR still pending?

@Vortrix5
Copy link
Contributor Author

Vortrix5 commented Mar 5, 2025

@laurent22 Any update on this PR?

@laurent22 laurent22 merged commit 215f09d into laurent22:dev Mar 8, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants