Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: improve download in install script #11921

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

tessus
Copy link
Collaborator

@tessus tessus commented Mar 4, 2025

This is a follow-up PR to #11889

Some distros replaced wget with wget2, but did nor set an alias. Some others have neither installed by default, but use curl instead.
However, it is almost certain that at least one is installed.

@sudokillnine here's the PR I mentioned earlier.

This change checks for the usual suspects for downloading on the command line: wget2, wget, and curl.
If none of them are found, an error is shown and the script exits.

@tessus tessus added the linux label Mar 4, 2025
@tessus
Copy link
Collaborator Author

tessus commented Mar 4, 2025

If no one objects, I'll merge tomorrow evening: 2025-03-04 18:00 EST.

@sudokillnine
Copy link

Hello Tessus,

Thank you for the update of the script, I was too busy to work on it last week.

I tested the script with curl, wget and wget2 on Debian 12 and with curl and wget2 on Fedora 41.

it works well, thanks 👍

@laurent22
Copy link
Owner

Looks good to me

@tessus
Copy link
Collaborator Author

tessus commented Mar 5, 2025

Thanks for the review. I've been hacking bash scripts for 3 decades now, but this doesn't mean that I never make mistakes. ;-) Although I tested this change at home before opening the PR.

@tessus tessus merged commit 67ae0ea into laurent22:dev Mar 5, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants