-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translation improvement for zh_CN #11922
Conversation
clsty
commented
Mar 4, 2025
- Improve simplified Chinese translation for corrections, readability and corrections, etc.
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see inline comment
Other than that, LGTM. Thanks for the update
Oh, and you have to sign the CLA. see #11922 (comment) |
I'm heading to bed. I'm going to look at it tomorrow. |
I have read the CLA Document and I hereby sign the CLA |
That's a really quick response. Thanks for reviewing. I've added the comments back. However may I ask why they are still needed btw? |
Thank you for adding the comments back. The reason for keeping them around is as follows: The translation files are generated from the source code. It is quite possible that a change in the code will be reverted at a later point or a similar text is used as what was previously used and translated. Additionally, the .po file are not used in the product. They are converted to JSON files and all comments are stripped out anyway. |