Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation improvement for zh_CN #11922

Merged
merged 3 commits into from
Mar 4, 2025
Merged

Translation improvement for zh_CN #11922

merged 3 commits into from
Mar 4, 2025

Conversation

clsty
Copy link
Contributor

@clsty clsty commented Mar 4, 2025

  • Improve simplified Chinese translation for corrections, readability and corrections, etc.

Copy link
Contributor

github-actions bot commented Mar 4, 2025

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Copy link
Collaborator

@tessus tessus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see inline comment

Other than that, LGTM. Thanks for the update

@tessus tessus added the translation i18n and l10n label Mar 4, 2025
@tessus
Copy link
Collaborator

tessus commented Mar 4, 2025

Oh, and you have to sign the CLA. see #11922 (comment)

@tessus
Copy link
Collaborator

tessus commented Mar 4, 2025

I'm heading to bed. I'm going to look at it tomorrow.

@clsty
Copy link
Contributor Author

clsty commented Mar 4, 2025

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Mar 4, 2025
@clsty
Copy link
Contributor Author

clsty commented Mar 4, 2025

see inline comment

Other than that, LGTM. Thanks for the update

That's a really quick response. Thanks for reviewing.

I've added the comments back. However may I ask why they are still needed btw?

@tessus
Copy link
Collaborator

tessus commented Mar 4, 2025

Thank you for adding the comments back.

The reason for keeping them around is as follows: The translation files are generated from the source code. It is quite possible that a change in the code will be reverted at a later point or a similar text is used as what was previously used and translated.
We also do not use annotations in translation files, which would help in certain situations to understand the meaning of the text and to translate it properly. Literal translations are often wrong and need correction. If there are a valid translations in the comments, they can help a translator.
I'm not sure but Poedit might make use of them for translation suggestions.

Additionally, the .po file are not used in the product. They are converted to JSON files and all comments are stripped out anyway.

@tessus tessus merged commit cdb61b9 into laurent22:dev Mar 4, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation i18n and l10n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants