Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 2 items in carousel #446

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Aman1919
Copy link

@Aman1919 Aman1919 commented Feb 15, 2025

Notes for Reviewers

This PR fixes #437

Screencast.from.2025-02-15.16-16-07.webm

Signed commits

  • Yes, I signed my commits.

Sorry, something went wrong.

Signed-off-by: AMAN SINGH <89124765+Aman1919@users.noreply.github.com>
Copy link

netlify bot commented Feb 15, 2025

Deploy Preview for bejewelled-pegasus-b0ce81 ready!

Name Link
🔨 Latest commit f3ec797
🔍 Latest deploy log https://app.netlify.com/sites/bejewelled-pegasus-b0ce81/deploys/67b071582b5c040008283110
😎 Deploy Preview https://deploy-preview-446--bejewelled-pegasus-b0ce81.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vishalvivekm
Copy link
Contributor

@Aman1919
Thank you for your contribution!
Let's discuss this during the website call on Today at 7 AM CT | 6:30 PM IST
adding it as an agenda item to the meeting minutes.

@leecalcote
Copy link
Member

@Vidit-Kushwaha will you offer review here?

Copy link

@Vidit-Kushwaha Vidit-Kushwaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 // Thanks @Aman1919

@leecalcote leecalcote requested a review from vishalvivekm March 3, 2025 21:22
<script>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aman1919 I would much prefer a CSS-only implementation. Can you make this happen?

@leecalcote
Copy link
Member

@vishalvivekm, please steward this forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

[video] more on-screen slides in carousel
4 participants