Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 2 items in carousel #446

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion assets/scss/_videos.scss
Original file line number Diff line number Diff line change
@@ -77,4 +77,16 @@
.carousel-indicators button.active {
background-color: #fff;
opacity: 1;
}
}


/* medium and up screens */
@media (min-width: 768px) {
.carousel-inner .carousel-item.active,
.carousel-inner .carousel-item-next,
.carousel-inner .carousel-item-prev, .carousel-inner {
display: flex;
}

}

31 changes: 23 additions & 8 deletions layouts/partials/video-section-related.html
Original file line number Diff line number Diff line change
@@ -26,7 +26,7 @@
{{ if gt $matchScore 0 }}
{{ $matchingVideos = $matchingVideos | append (dict "page" $page "score" $matchScore) }}
{{ end }}

{{ end }}

{{ $sortedVideos := sort $matchingVideos "score" "desc" }}
@@ -46,9 +46,9 @@ <h2>Related Videos</h2>

<div class="carousel-inner">
{{ range $index, $video := $sortedVideos }}
<div class="carousel-item {{ if eq $index 0 }}active{{ end }}">
<div class="row justify-content-center">
<div class="col-12 col-md-8 col-lg-6">
<div class="carousel-item justify-content-around {{ if eq $index 0 }}active{{ end }}">

<div class="col-12 col-md-7 col-lg-5">
<a href="{{ .page.RelPermalink }}" class="video-link text-decoration-none">
<div class="video card h-100 bg-dark text-white border border-secondary shadow-lg p-1">
<div class="video-container position-relative"
@@ -73,7 +73,6 @@ <h4 class="video-title text-white mb-0">{{ .page.Title }}</h4>
</div>
</a>
</div>
</div>
</div>
{{ end }}
</div>
@@ -92,6 +91,22 @@ <h4 class="video-title text-white mb-0">{{ .page.Title }}</h4>
</div>


<style>

</style>
<script>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aman1919 I would much prefer a CSS-only implementation. Can you make this happen?


if (window.matchMedia("(min-width: 768px)").matches) {
let items = document.querySelectorAll('.carousel .carousel-item')
items.forEach((el) => {
const minPerSlide = 2;
let next = el.nextElementSibling;
for (var i = 1; i < minPerSlide; i++) {
if (!next) {
// wrap carousel by using first child
next = items[0];
}
let cloneChild = next.cloneNode(true);
el.appendChild(cloneChild.children[0]);
next = next.nextElementSibling;
}
});
}
</script>