feat: tab new component #6280
feat: tab new component #6280
Conversation
|
🚀 Preview for commit e885203 at: https://67c6c4ce7fbc5fe040bc2a5d--layer5.netlify.app |
Signed-off-by: Jaishree2310 <jaishrees23102001@gmail.com>
Jaishree2310
force-pushed
the
tab-new-component
branch
from
e885203 to
05adcc9
Compare
|
🚀 Preview for commit 05adcc9 at: https://67c70ff436fb06006e5c0da5--layer5.netlify.app |
| ? "active" | ||
| : "" | ||
| } | ||
| onClick={() => navigate("/projects/sistent/components/tab")} |
There was a problem hiding this comment.
@Jaishree2310 There is a typo here, it redirects to an error page.
It should be: /projects/sistent/components/tabs
| onClick={() => navigate("/projects/sistent/components/tab")} | |
| onClick={() => navigate("/projects/sistent/components/tabs")} |
|
@Jaishree2310, I might have missed some updates here, but I’d recommend checking your implementation’s UI by running the website locally. It’s important to take the time to understand the codebase before working on issues. I also noticed a similar concern with the avatar component, especially in the code section. It would be great if you could review your work carefully before submitting. This will help reduce the number of improvement suggestions needed. I truly appreciate your efforts, and I’m sure you’ll get better with time! You will find your commits preview, similar to this one: 
|
|
You can see that your code preview differs in the code section. I’d like it to match the one shown below: 
|
Description
This PR fixes #5961
Notes for Reviewers
Signed commits