added istio and osm service mesh #41
Merged
+76
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kumarabd <abishekkumar92@gmail.com>
leecalcote
reviewed
Aug 13, 2020
leecalcote
reviewed
Aug 13, 2020
| @@ -21,7 +21,12 @@ var ( | |||
| PortSvcB: "9091", | |||
| PortSvcC: "9091", | |||
| } | |||
| istioConfig = &test_gen.Linkerd{ | |||
There was a problem hiding this comment.
@kumarabd do we still support Linkerd? Or was our support incomplete earlier?
@leecalcote yes should work. |
leecalcote
approved these changes
Aug 13, 2020
leecalcote
reviewed
Aug 13, 2020
| docker push smi-conformance:${GITHUB_SHA::6} | ||
| cd ../smi-conformance && docker build --no-cache -t ${{ secrets.IMAGE_NAME }}:smi . | ||
| docker tag ${{ secrets.IMAGE_NAME }}:smi ${{ secrets.IMAGE_NAME }}:smi-${GITHUB_SHA::6} | ||
| docker push ${{ secrets.IMAGE_NAME }}:smi |
There was a problem hiding this comment.
@kumarabd given the update to the tag name of smi, we may have to update adapter logic accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: kumarabd abishekkumar92@gmail.com
Description
This PR fixes #40
Notes for Reviewers
Signed commits