Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reserved port from 10008 to 10011 #56

Merged
merged 1 commit into from Sep 12, 2020
Merged

Update reserved port from 10008 to 10011 #56

merged 1 commit into from Sep 12, 2020

Conversation

ghost
Copy link

@ghost ghost commented Sep 11, 2020

Signed-off-by: Efereyan Karen Simisola thedevkaren@gmail.com

Description

This PR fixes #54

Notes for Reviewers

Signed commits

  • [x ] Yes, I signed my commits.

Signed-off-by: Efereyan Karen Simisola <thedevkaren@gmail.com>
@welcome
Copy link

welcome bot commented Sep 11, 2020

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

@ghost
Copy link
Author

ghost commented Sep 11, 2020

@leecalcote and @crustyy kindly review my PR. Now, I will go and update the Meshery docs to reflect the network port being used here

@leecalcote leecalcote merged commit f4ba68e into layer5io:master Sep 12, 2020
@welcome
Copy link

welcome bot commented Sep 12, 2020

Thanks for your contribution to the Layer5 community! 🎉

Congrats!

      ⭐ Please star the project if you have yet to do so and sure to join the community Slack.

@ghost
Copy link
Author

ghost commented Sep 12, 2020

@leecalcote thanks. Im just about to go sleep

@ghost ghost deleted the feat/KarenEfereyan/54 branch September 12, 2020 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Update reserved network port
1 participant