Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Manifest and some SMI Changes #76

Merged
merged 6 commits into from
Mar 17, 2021

Conversation

dhruv0000
Copy link
Member

@dhruv0000 dhruv0000 commented Mar 11, 2021

Co-authored-by: abishek kumarabd@users.noreply.github.com
Signed-off-by: dhruv0000 patel.4@iitj.ac.in

Description

This PR fixes:

  • The percentage calculations
  • Fixed #37
  • Updated smi-conformance service to LoadBalancer

Notes for Reviewers

  • Need to change dhruv0000/learn-layer5:smi in smi-conformance/manifest.yaml to layer5/learn-layer5:smi, once approved.

Signed commits

  • Yes, I signed my commits.

dhruv0000 and others added 3 commits March 11, 2021 23:13
Co-authored-by: abishek <kumarabd@users.noreply.github.com>
Signed-off-by: dhruv0000 <patel.4@iitj.ac.in>
Signed-off-by: dhruv0000 <patel.4@iitj.ac.in>
Signed-off-by: dhruv0000 <patel.4@iitj.ac.in>
@dhruv0000 dhruv0000 requested a review from kumarabd March 16, 2021 22:32
@dhruv0000 dhruv0000 changed the title Updated Manifest Updated Manifest and some SMI Changes Mar 16, 2021
@dhruv0000 dhruv0000 marked this pull request as ready for review March 16, 2021 22:33
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than dhruv0000 image location, this LGTM

Signed-off-by: dhruv0000 <patel.4@iitj.ac.in>
Signed-off-by: dhruv0000 <patel.4@iitj.ac.in>
@dhruv0000 dhruv0000 requested a review from kumarabd March 17, 2021 07:27
Signed-off-by: dhruv0000 <patel.4@iitj.ac.in>
@kumarabd kumarabd merged commit 06b4f88 into layer5io:master Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[SMI Conformance] Tests for Kuma are failing
3 participants