feat: add similar design by type #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: TheFaheem <faheemmushtaq89@gmail.com>
sudhanshutech
suggested changes
Feb 25, 2025
There was a problem hiding this comment.
@FaheemOnHub few things.
- I guess you don't need to show arrow icons when there are not enough cards to scroll.
- The arrow icons shouldn't be overflowing outside the container
sudhanshutech
suggested changes
Feb 25, 2025
Signed-off-by: TheFaheem <faheemmushtaq89@gmail.com>
|
@FaheemOnHub was all review implemented. If yes the merge conflict and lint failing. |
Signed-off-by: TheFaheem <faheemmushtaq89@gmail.com>
Signed-off-by: TheFaheem <35933338+FaheemOnHub@users.noreply.github.com>
Signed-off-by: TheFaheem <faheemmushtaq89@gmail.com>
Signed-off-by: TheFaheem <faheemmushtaq89@gmail.com>
Signed-off-by: TheFaheem <faheemmushtaq89@gmail.com>
its fixed |
amitamrutiya
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes depends on: https://github.com/layer5io/meshery-cloud/pull/3217
Changes:
Signed commits