fix: improve info messages for model and design import modals #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Riya Garg <riyag1452003@gmail.com>
|
@amitamrutiya @Vidit-Kushwaha can you please review this PR? |
1 task
amitamrutiya
approved these changes
Feb 28, 2025
|
@riyaa14 have you finish all of your testing? |
|
@amitamrutiya thanks for reviewing! exactly what in testing, I didn't get it? |
leecalcote
reviewed
Feb 28, 2025
leecalcote
reviewed
Feb 28, 2025
leecalcote
reviewed
Feb 28, 2025
leecalcote
reviewed
Feb 28, 2025
Co-authored-by: Lee Calcote <leecalcote@gmail.com> Signed-off-by: Riya Garg <96983874+riyaa14@users.noreply.github.com>
Co-authored-by: Lee Calcote <leecalcote@gmail.com> Signed-off-by: Riya Garg <96983874+riyaa14@users.noreply.github.com>
Signed-off-by: Riya Garg <96983874+riyaa14@users.noreply.github.com>
Signed-off-by: Riya Garg <96983874+riyaa14@users.noreply.github.com>
Vidit-Kushwaha
approved these changes
Mar 2, 2025
This was referenced Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR fixes #
Prev behaviour: This schema was present in meshkit schemas and fetched via server (api/schema/resource/{resourcename})
Current behaviour: Schema fetched from sistent.
Why? To keep it consistent with Filter and Design. Meshkit Schemas are deprecated.
Before
After
Signed commits