[CI] Replace npm with make commands and use them in workflows
#950
Conversation
…efile Signed-off-by: shinigami-777 <chattopadhyaytamaghna@gmail.com>
Signed-off-by: shinigami-777 <chattopadhyaytamaghna@gmail.com>
Signed-off-by: shinigami-777 <chattopadhyaytamaghna@gmail.com>
|
@leecalcote I have tested that all the mentioned make commands are working and the workflow runs are successful on my branch. https://github.com/shinigami-777/sistent/actions/runs/13609283622 |
|
Running workflows... |
.github/workflows/node-checks.yml
Outdated
|
|
||
| - name: Run Tests | ||
| run: npm run test | ||
| run: make run-tests |
There was a problem hiding this comment.
Invert please. Noun first, verb second.
Makefile
Outdated
| npm run build | ||
|
|
||
| package-build-watch: setup | ||
| ## Buid Sistent in watch mode | ||
| build-watch: |
There was a problem hiding this comment.
Renamed it to watch-build. Does this work?
There was a problem hiding this comment.
verb-verb? No, it does not work. Refer to our other projects for examples.
There was a problem hiding this comment.
I referred to the examples but was unable to find an exact case (it did help me understand the naming scheme) Suggesting a few as I'm not very confident with my naming...dev-build , watchmode-build, watcher-build. Do these work?
There was a problem hiding this comment.
Renamed it to watchmode-build.
Makefile
Outdated
| npm run lint | ||
|
|
||
| ## Run tests | ||
| run-tests: |
| npm run format:write | ||
|
|
||
| ## Run Eslint on your local machine | ||
| lint: |
There was a problem hiding this comment.
Do we need two separate commands for formatting and linting? Combine them?
There was a problem hiding this comment.
Yes, combined both under a single make lint command.
Signed-off-by: shinigami-777 <chattopadhyaytamaghna@gmail.com>
Signed-off-by: shinigami-777 <chattopadhyaytamaghna@gmail.com>
Notes for Reviewers
This PR fixes #942 .
Makefile.show-help.mkfile frommeshery/meshery.README.mdandCONTRIBUTING.mdaccordingly.Signed commits