-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implemented hover effects for widget links #952
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: PR4NJ41 <pranjal.rajput.che21@itbhu.ac.in>
Signed-off-by: PR4NJ41 <pranjal.rajput.che21@itbhu.ac.in>
alignItems: 'center', | ||
'&:hover': { | ||
filter: 'invert(50%) sepia(30%) saturate(1000%) hue-rotate(120deg)' | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rather then adding the filter use the our brand theme color for the hover effect and remove underline when hovering
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amitamrutiya I used filter
to apply color to the icon.
If you’d like to remove the filter
, I can convert styled(icon)
to styled(div)
and use maskImage
for styling instead. Would you like me to proceed with that approach?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can dynimcally change the fill color of the icon when hover effect trigger in the parent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are using row svg then try with converting this into icon.
Signed-off-by: PR4NJ41 <pranjal.rajput.che21@itbhu.ac.in>
@PR4NJ41 |
Notes for Reviewers
Latest Blogs
andHelp Center
widgetsScreenshots
Fix.mp4
Signed commits