Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implemented hover effects for widget links #952

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

PR4NJ41
Copy link
Contributor

@PR4NJ41 PR4NJ41 commented Mar 2, 2025

Notes for Reviewers

Screenshots

Fix.mp4

Signed commits

  • Yes, I signed my commits.

PR4NJ41 added 2 commits March 2, 2025 15:15
Signed-off-by: PR4NJ41 <pranjal.rajput.che21@itbhu.ac.in>
Signed-off-by: PR4NJ41 <pranjal.rajput.che21@itbhu.ac.in>
Comment on lines +30 to +33
alignItems: 'center',
'&:hover': {
filter: 'invert(50%) sepia(30%) saturate(1000%) hue-rotate(120deg)'
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rather then adding the filter use the our brand theme color for the hover effect and remove underline when hovering

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amitamrutiya I used filter to apply color to the icon.
If you’d like to remove the filter, I can convert styled(icon) to styled(div) and use maskImage for styling instead. Would you like me to proceed with that approach?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can dynimcally change the fill color of the icon when hover effect trigger in the parent.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are using row svg then try with converting this into icon.

Signed-off-by: PR4NJ41 <pranjal.rajput.che21@itbhu.ac.in>
@vishalvivekm
Copy link
Contributor

@PR4NJ41
Let's discuss this during the website call today at 6:30 PM IST.
Adding it as an agenda item to the meeting minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[UI] Dashboard Widget: Latest Blogs enhancements
3 participants