[ImportVerilog] add unpacked array concatenation #8270
Conversation
chenbo-again
force-pushed
the
unpacked_array_concat
branch
from
df474e2 to
f642779
Compare
|
This PR import UnpackedArrayConcatOp operation, This Operation is very similar to array_create operation, but can use unpacked array as operands. |
| let summary = [{ | ||
| This operation represents the SystemVerilog unpacked array concatenation, | ||
| See IEEE 1800-2017 §10.10 "Unpacked array concatenation". | ||
|
|
||
| - An item whose self-determined type is assignment compatible with the | ||
| element type of the target array shall represent a single element, | ||
| - An item whose self-determined type is an unpacked array whose | ||
| slowest-varying dimension's element type is assignment compatible | ||
| with the element type of the target array shall represent as many | ||
| elements as exist in that item, arranged in the same left-to-right order | ||
| as they would appear in the array item itself. | ||
| }]; | ||
| let description = [{}]; |
There was a problem hiding this comment.
nit: please exchange their content.
| @@ -993,6 +1003,7 @@ module Expressions; | |||
| // CHECK: moore.extract_ref %vec_1 from 11 : <l32> -> <l3> | |||
| vec_1[15-:3] = y; | |||
|
|
|||
| vec_s = { "hello", "sad", "world" }; | |||
There was a problem hiding this comment.
If there isn't stringConcat, you have to remove it. Otherwise, you should add // CHECK: s to test it.
| def AnyIndexedUnpackedArrayType : MooreType< | ||
| Or<[UnpackedArrayType.predicate, OpenUnpackedArrayType.predicate, QueueType.predicate]>, | ||
| "unpacked array type except associative array type", | ||
| "moore::UnpackedType">; |
There was a problem hiding this comment.
I noticed that UnpackedArrayType, OpenUnpackedArrayType, and QueueType are all AnyIndexedUnpackedArrayType, but you just tested the OpenUnpackedArrayType, the others you also have to test.
| if (isAssignmentContextRhs) { | ||
| switch (expr.kind) { | ||
| case slang::ast::ExpressionKind::Concatenation: { | ||
| auto isUnpackedArray = [](Type arg) { | ||
| return isa<moore::UnpackedArrayType, moore::OpenUnpackedArrayType, | ||
| moore::QueueType>(arg); | ||
| }; | ||
| if (!isUnpackedArray(requiredType)) | ||
| return convertRvalueExpression(expr, requiredType); | ||
| SmallVector<Value> operands; | ||
|
|
||
| const auto &concatExpr = | ||
| static_cast<const slang::ast::ConcatenationExpression &>(expr); | ||
| Type elementType = getArrayElementsType(requiredType); | ||
|
|
||
| for (auto *operand : concatExpr.operands()) { | ||
| auto value = convertRvalueExpression(*operand); | ||
| if (!value) | ||
| continue; | ||
|
|
||
| if (!isUnpackedArray(value.getType()) && elementType != value.getType()) | ||
| value = builder.create<moore::ConversionOp>(loc, elementType, value); | ||
|
|
||
| operands.push_back(value); | ||
| } | ||
| return builder.create<moore::UnpackedArrayConcatOp>(loc, requiredType, | ||
| operands); | ||
| } | ||
|
|
||
| default: | ||
| return convertRvalueExpression(expr, requiredType); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
You should move this code snippet to the proper place, like Value visit(const slang::ast::ConcatenationExpression &expr).
There was a problem hiding this comment.
By the way, maybe you can check the following case(it's mentioned at SV IEEE Std 10.10.3):
typedef int T_QI[$];
T_QI jagged_array[$] = '{ {1}, T_QI'{2,3,4}, {5,6} };
This PR is aimed to provide unpacked array concatenation.
these two operation do not act the same way, and the result of concat is depends on the Lhs.
close #8173