Add the BLIF dialect. #8019
Open
Add the BLIF dialect. #8019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 29, 2024 00:53
The BLIF dialect implements the extended berkely logic interchange format. This is a format used by some OSS tools, such as some place-and-route tools. This is the format used by yosys to interchange with nextpnr.
|
Will join with #8018 to push an fpga-mapped design to nextpnr. |
added 3 commits
January 3, 2025 21:57
fabianschuiki
approved these changes
Jan 9, 2025
| include "mlir/IR/EnumAttr.td" | ||
| include "mlir/IR/RegionKindInterface.td" | ||
|
|
||
| def ModelOp : BLIFOp<"model", [IsolatedFromAbove, RegionKindInterface, SingleBlockImplicitTerminator<"OutputOp">]> { |
There was a problem hiding this comment.
Nit: overly long line
Comment on lines
34
to
37
| OpBuilder<(ins "StringRef":$name, | ||
| "ArrayRef<StringRef>":$inputs, | ||
| "ArrayRef<StringRef>":$outputs, | ||
| "ArrayRef<StringRef>":$clocks)> |
There was a problem hiding this comment.
Omega-nit: " alignment
Max-astro
reviewed
Mar 5, 2025
| namespace circt { | ||
| namespace blif { | ||
|
|
||
| /// This represents a specific token for .fir files. |
There was a problem hiding this comment.
Should it be ".blif" files?
Max-astro
reviewed
Mar 6, 2025
There was a problem hiding this comment.
Thank you so much for implementing the BLIF parser. It's great to see the CIRCT project can handle .blif files, and your implementation is a good example of how to implement a lexer and parser. I'm currently implementing a liberty parser based on your BLIF parser, and I want you to know that I found some incorrect descriptions in your comments.
|
|
||
| class BLIFLexerCursor; | ||
|
|
||
| /// This implements a lexer for .fir files. |
| // NOLINTBEGIN(misc-no-recursion) | ||
| namespace { | ||
|
|
||
| /// An emitter for FIRRTL dialect operations to .fir output. |
|
|
||
| class BLIFLexerCursor; | ||
|
|
||
| /// This implements a lexer for .fir files. |
| bool encounteredError = false; | ||
|
|
||
| /// The names used to emit values already encountered. Anything that gets a | ||
| /// name in the output FIR is listed here, such that future expressions can |
| TOK_LITERAL(cover) // 0--1- | ||
| TOK_LITERAL(bit) // 0 || 1 | ||
|
|
||
| // Keywords. These turn "foo" into FIRToken::kw_foo enums. |
There was a problem hiding this comment.
nit: Update comment or remove this line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BLIF dialect implements the extended berkely logic interchange format. This is a format used by some OSS tools, such as some place-and-route tools. This is the format used by yosys to interchange with nextpnr.