[circt-verilog-lsp] Add definition and reference providers #8280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds "Go to Definition" and "Find References" functionality to the CIRCT Verilog LSP server. These features allow users to navigate between symbol definitions and usages within Verilog source files. - Added VerilogIndex class to track symbol definitions and references - Implemented source location parsing for external file references - Added support for LSP definition and reference requests - Extended server capabilities to advertise the new functionality - Added test cases to verify the new features Following PDLL's LSP implemetation, the implementation uses an IntervalMap to efficiently map source positions to symbols, allowing quick lookups when users request definitions or references. It also supports source location annotations in comments that can link to external MLIR files, enabling cross-language navigation.
uenoku
force-pushed
the
dev/hidetou/lsp-features/def
branch
from
bbf0fca to
47e6e38
Compare
uenoku
commented
Mar 6, 2025
uenoku
commented
Mar 7, 2025
| if (!intervalIt.valid() || posLoc.getPointer() < intervalIt.start()) | ||
| return; | ||
|
|
||
| const auto *symbol = cast<const slang::ast::Symbol *>(intervalIt.value()); |
There was a problem hiding this comment.
Suggested change
| const auto *symbol = cast<const slang::ast::Symbol *>(intervalIt.value()); | |
| const auto *symbol = dyn_cast<const slang::ast::Symbol *>(intervalIt.value()); |
uenoku
commented
Mar 7, 2025
Comment on lines
+812
to
+813
| circt::lsp::Logger::info(std::to_string(defPos.line) + ":" + | ||
| std::to_string(defPos.character)); |
There was a problem hiding this comment.
Suggested change
| circt::lsp::Logger::info(std::to_string(defPos.line) + ":" + | |
| std::to_string(defPos.character)); |
uenoku
commented
Mar 7, 2025
|
|
||
| auto element = it.value(); | ||
| if (auto attr = dyn_cast<Attribute>(element)) { | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds "Go to Definition" and "Find References" functionality to the CIRCT Verilog LSP server. These features allow users to navigate between symbol definitions and usages within Verilog source files. Besides it provides cross references for source location comments.
Following PDLL's LSP implemetation, the implementation uses an IntervalMap to efficiently map source positions
to symbols, allowing quick lookups when users request definitions or references. It also supports source location annotations in comments that can link to external source files, enabling cross-language navigation.