[SCFToCalyx] Lower Arith Bitcast #8294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgyurgyik
approved these changes
Mar 4, 2025
| @@ -1500,6 +1501,12 @@ LogicalResult BuildOpGroups::buildOp(PatternRewriter &rewriter, | |||
| return res; | |||
| } | |||
|
|
|||
| LogicalResult BuildOpGroups::buildOp(PatternRewriter &rewriter, | |||
There was a problem hiding this comment.
Suggested change
| LogicalResult BuildOpGroups::buildOp(PatternRewriter &rewriter, | |
| // The Calyx language treats values as bit vectors, i.e., there is no type system, | |
| // so this is essentially a no-op. | |
| LogicalResult BuildOpGroups::buildOp(PatternRewriter &rewriter, |
cgyurgyik
reviewed
Mar 4, 2025
| @@ -1500,6 +1501,12 @@ LogicalResult BuildOpGroups::buildOp(PatternRewriter &rewriter, | |||
| return res; | |||
| } | |||
|
|
|||
| LogicalResult BuildOpGroups::buildOp(PatternRewriter &rewriter, | |||
There was a problem hiding this comment.
Please add a small unit test as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my current proposal on how to lower
arith.bitcastshould be lowered, not 100% sure.Since Calyx treat everything as bit vectors, I just keep every bit unchanged.