Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance cir.atomic.cmp_xchg and cir.atomic.xchg verifiers #1378

Open
bcardosolopes opened this issue Feb 20, 2025 · 5 comments · May be fixed by #1431
Open

Enhance cir.atomic.cmp_xchg and cir.atomic.xchg verifiers #1378

bcardosolopes opened this issue Feb 20, 2025 · 5 comments · May be fixed by #1431
Labels
good first issue Good for newcomers

Comments

@bcardosolopes
Copy link
Member

This is comparing contents of the object pointed to by a !cir.ptr<!ty_S> pointer to a !u64i value

Originally posted by @bcardosolopes in #1373 (comment)
@bcardosolopes bcardosolopes mentioned this issue Feb 20, 2025
Merged
@bcardosolopes bcardosolopes added the good first issue Good for newcomers label Feb 20, 2025
@Icaro-Nunes
Copy link

Hello, I'm new here and would like to contribute! Can you provide more information on this issue? I have read the mentioned PR and previous issue but could not understand completely what enhancements should be made.

@bcardosolopes
Copy link
Member Author

Hi @Icaro-Nunes, the pointee should match the value to compare, should be implemented in the ::verify method for both operations

@Icaro-Nunes
Copy link

Ok, I'm looking at it!

@Icaro-Nunes Icaro-Nunes linked a pull request Mar 1, 2025 that will close this issue
Open
@Icaro-Nunes
Copy link

Hello @bcardosolopes , I just opened a draft PR for this issue! I think the only thing I was not able to figure out is how to write a test that forces the type checking in ::verify to fail, since most attempts get caught at function argument checking (there is an example in the PR).

@bcardosolopes
Copy link
Member Author

bcardosolopes commented Mar 5, 2025 •
edited
Loading

I didn't see it, thanks for reaching out. Added a comments over there!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[CIR] Implement ::verify for cir.atomic.xchg and cir.atomic.cmp_xchg Icaro-Nunes/clangir
2 participants
@bcardosolopes @Icaro-Nunes